Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to not use logger from pipeline #760

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Sep 18, 2020

This is a refactoring to not use logger from
tektoncd/pipeline as it can be directly used from
knative.dev/pkg and also it has been from the
pipeline repo tektoncd/pipeline#3058
so whever there is a dependency bump it needs to
be done.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

   NONE

This is a refactoring to not use logger from
tektoncd/pipeline as it can be directly used from
knative.dev/pkg and also it has been from the
pipeline repo tektoncd/pipeline#3058
so whever there is a dependency bump it needs to
be done.
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 18, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2020
@piyush-garg
Copy link
Contributor Author

logger pkg has been removed from the pipeline using PR tektoncd/pipeline#3058

This is causing issue for cli as we want to bump the dependency to v0.16.3 of pipelines, go mod tidy is failing as the pkg is not available anymore in vendor and tektoncd/triggers need it. We will need to bump the triggers to this commit now.

cc @dibyom @savitaashture @khrm @dlorenc @vdemeester @danielhelfand

@dibyom
Copy link
Member

dibyom commented Sep 18, 2020

Thanks @piyush-garg
/kind cleanup
/approve
/lgtm

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. labels Sep 18, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2020
@tekton-robot tekton-robot merged commit 8cef2e8 into tektoncd:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants