Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cel-go with string upper and lower-casing. #766

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

bigkevmcd
Copy link
Member

@bigkevmcd bigkevmcd commented Sep 22, 2020

Changes

Brings in cel-go v0.6.0 with additional functionality for lower and upper-casing strings.

Fixes: #759
Fixes: #638

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Updated version of cel-go with new functionality for upper and lower-casing ASCII strings.

New functionality for the CEL interceptor, with functions for upper and lower-casing ASCII strings.

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 22, 2020
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 22, 2020
@bigkevmcd bigkevmcd changed the title Add test with lowerCase of a string. cel-go with string upper and lower-casing. Sep 22, 2020
This brings in cel-go v0.6.0.

This adds support for upper and lower-casing ASCII strings.
@bigkevmcd bigkevmcd marked this pull request as ready for review September 22, 2020 18:52
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2020
@dibyom
Copy link
Member

dibyom commented Sep 23, 2020

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@tekton-robot tekton-robot merged commit 0fd9b8f into tektoncd:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I wish to customize the pipeline name CEL feature: string casing functions
3 participants