Fix Binding builder to only use ref #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testbuilder `EventListenerTriggerBinding` allows users to specify both `name` and `ref` fields. With tektoncd#617, specifying both `name` and `ref` is no longer allowed. We fixed the builder usage for all the happy path tests to use `name` as an empty string but did not do it for tests that are verifying error paths (such as validation errors). So, these tests will now all fail at the same validation check making most of these tests useless (causing the drop in coverage in To fix, I changed the builder to only accept `ref` so that one cannot create invalid structs. Later, we can migrate our tests to not use builders at all and have our error tests verify the actual error string. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
3 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The testbuilder
EventListenerTriggerBindingallows users to specify bothnameandreffields. With #617, specifying bothnameandrefis nolonger allowed.
We fixed the builder usage for all the happy path tests to use
nameas anempty string but did not do it for tests that are verifying error paths (such
as validation errors). So, these tests will now all fail at the same validation
check making most of these tests useless (causing the drop in coverage in
To fix, I changed the builder to only accept
refso that one cannot createinvalid structs. Later, we can migrate our tests to not use builders at all and
have our error tests verify the actual error string.
Signed-off-by: Dibyo Mukherjee dibyo@google.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes