Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the pod resource to the test controller #780

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Add the pod resource to the test controller #780

merged 1 commit into from
Sep 30, 2020

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Sep 30, 2020 •
edited by dibyom
Loading

Add the pod resource to the test controller which is used by tkn cli to test el pod.
Fixes #779

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 30, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 30, 2020
@khrm khrm added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 30, 2020
@khrm
Add the pod resource to the test controller
0a71bc7 
Add the pod resource to the test controller which is used by
tkn cli to test el pod.
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
test/controller.go 73.0% 72.9% -0.0

savitaashture
savitaashture reviewed Sep 30, 2020
View reviewed changes
vendor/knative.dev/pkg/client/injection/kube/informers/core/v1/pod/fake/fake.go
@@ -0,0 +1,40 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how this file added?
is there any changes in go.mod file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its package is already under go.mod. Changes are in vendor/modules.txt file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its due to the new import here: fakepodinformer "knative.dev/pkg/client/injection/kube/informers/core/v1/pod/fake"

@dibyom
Copy link
Member

dibyom commented Sep 30, 2020

/approve
/lgtm
/kind misc

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. labels Sep 30, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 30, 2020
@tekton-robot tekton-robot merged commit 566f42e into tektoncd:master Sep 30, 2020
@khrm khrm deleted the ctrlPod branch September 30, 2020 18:03
@khrm khrm removed the kind/feature Categorizes issue or PR as related to a new feature. label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@ncskier ncskier Awaiting requested review from ncskier

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Pods as Test Data in Mock Controllers
4 participants
@khrm @tekton-robot @dibyom @savitaashture