Don't log Fatal when handling events in the eventlistener #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event. For this case, Fatalf causes the process to exit, and so the container cycles. This also adds a little bit of testing for this functionality, and to do so brings in a slightly newer version of the zap logging package.
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XL
|
/kind bug |
dibyom
reviewed
Oct 22, 2020
| @@ -87,7 +90,7 @@ func getSinkAssets(t *testing.T, resources test.Resources, elName string, auth A | |||
| clients := test.SeedResources(t, ctx, resources) | |||
| test.AddTektonResources(clients.Kube) | |||
|
|
|||
| logger, _ := zap.NewProduction() | |||
| logger := zaptest.NewLogger(t) | |||
|
Thanks for the fix and adding the test! @bigkevmcd The other two places where we use |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Don't log with Fatal when we can't fetch resources.
For this case, Fatalf causes the process to exit, and so the container cycles.
Fixes: #809
I had a look through the other cases where we're using Fatalf on the logger, and they all look like non-user error cases
It's not clear whether or not these should also be fixed for example this pattern is used twice:
https://github.com/tektoncd/triggers/blob/master/pkg/client/injection/reconciler/triggers/v1alpha1/eventlistener/controller.go#L55
This issue also doesn't look like a user could trigger it:
https://github.com/tektoncd/triggers/blob/master/pkg/client/injection/reconciler/triggers/v1alpha1/eventlistener/reconciler.go#L134
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes