Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a test helper for rawExtension objects in tests #843

Merged

Conversation

shuheiktgw
Copy link
Contributor

Changes

Relates to #796

I've replaced some of the test functions with the RawExtension test helper. Thank you for your review!

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 25, 2020
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 25, 2020
@tekton-robot
Copy link

Hi @shuheiktgw. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom
Copy link
Member

dibyom commented Nov 30, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2020
@dibyom
Copy link
Member

dibyom commented Nov 30, 2020

I think we need to run go fmt on the files for the build tests to pass. Otherwise, looks good!

@dibyom
Copy link
Member

dibyom commented Dec 17, 2020

@shuheiktgw just need to run go fmt on the changed files. Otherwise good to go 😃

@shuheiktgw
Copy link
Contributor Author

@dibyom So sorry that I didn't notice your message 🙇
Now I fixed it so would you mind reviewing the pr again?

@dibyom
Copy link
Member

dibyom commented Dec 28, 2020

No worries, looks like we need to run goimports too! (Also, could you squash your commits?)


pkg/apis/triggers/v1alpha1/trigger_template_validation_test.go:20: File is not goimports-ed (goimports)
"context"

@shuheiktgw
Copy link
Contributor Author

@dibyom Sorry I fixed it and squashed the commits! 🙏

@dibyom
Copy link
Member

dibyom commented Dec 29, 2020

Thank you!
/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2020
@tekton-robot tekton-robot merged commit f9f9ad6 into tektoncd:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants