Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system.DefaultNamespace for interceptor urls #891

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jan 8, 2021

Changes

SYSTEM_NAMESPACE is set to the namespace of the EventListener by the reconciler
which means that with the current logic the interceptor url is wrong. Use
default namespace to always use tekton-pipelines as the namespace. This is
hardcoded and the logic is temporary till we implement #868.

/kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 8, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2021
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2021
SYSTEM_NAMESPACE is set to the namespace of the EventListener by the reconciler
which means that with the current logic the interceptor url is wrong. Use
default namespace to always use `tekton-pipelines` as the namespace. This is
hardcoded and the logic is temporary till we implement tektoncd#868.

Also, actually wire up the HTTP handler in the interceptors server.
@dibyom dibyom marked this pull request as ready for review January 11, 2021 00:50
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2021
@dibyom dibyom requested review from savitaashture and removed request for bobcatfish January 11, 2021 00:50
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [savitaashture,wlynch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 608bc75 into tektoncd:master Jan 11, 2021
@MarcelMue
Copy link
Member

@dibyom Can you explain why this was necessary? This currently completely breaks the usecase of running in a different namespace because it will always resolve the service name into a wrong namespace.

@dibyom
Copy link
Member Author

dibyom commented Jan 25, 2021

Can you explain why this was necessary? This currently completely breaks the usecase of running in a different namespace because it will always resolve the service name into a wrong namespace.

I thought SYSTEM_NAMESPACE was the namespace Triggers was installed in but it turns out we (also) use it for the namespace that the Event Listener was installed in :(

Tracking in #923

@dibyom dibyom deleted the ns branch January 25, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants