-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use system.DefaultNamespace for interceptor urls #891
Conversation
SYSTEM_NAMESPACE is set to the namespace of the EventListener by the reconciler which means that with the current logic the interceptor url is wrong. Use default namespace to always use `tekton-pipelines` as the namespace. This is hardcoded and the logic is temporary till we implement tektoncd#868. Also, actually wire up the HTTP handler in the interceptors server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture, wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dibyom Can you explain why this was necessary? This currently completely breaks the usecase of running in a different namespace because it will always resolve the service name into a wrong namespace. |
I thought SYSTEM_NAMESPACE was the namespace Triggers was installed in but it turns out we (also) use it for the namespace that the Event Listener was installed in :( Tracking in #923 |
Changes
SYSTEM_NAMESPACE is set to the namespace of the EventListener by the reconciler
which means that with the current logic the interceptor url is wrong. Use
default namespace to always use
tekton-pipelines
as the namespace. This ishardcoded and the logic is temporary till we implement #868.
/kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes