Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TektonConfig: keep-since not documented #419

Closed
fgiloux opened this issue Aug 8, 2022 · 4 comments
Closed

TektonConfig: keep-since not documented #419

fgiloux opened this issue Aug 8, 2022 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@fgiloux
Copy link

fgiloux commented Aug 8, 2022

Expected Behavior

have keep-since documented here:
https://tekton.dev/docs/operator/tektonconfig/

Actual Behavior

No mention of keep-since in the documentation

Additional Info

keep-since has been part of TektonConfig API for a while:
https://github.com/tektoncd/operator/blob/main/pkg/apis/operator/v1alpha1/tektonconfig_types.go#L58-L61
@sounix000
Copy link

sounix000 commented Aug 8, 2022 •
edited

JIRA issue: https://issues.redhat.com/browse/RHDEVDOCS-4312
Discussion thread: https://coreos.slack.com/archives/CSPS1077U/p1655202587530059

avinal added a commit to avinal/operator that referenced this issue Aug 8, 2022
@avinal
docs: add keep-since to TektonConfig docs
c5fef2a 
- Adds keep-since to TektonConfig docs
- Type Declaration: https://github.com/tektoncd/operator/blob/main/pkg/apis/operator/v1alpha1/tektonconfig_types.go#L58-L61
- Mutually exclusive keep and keep-since: https://github.com/tektoncd/operator/blob/main/pkg/apis/operator/v1alpha1/tektonconfig_validation.go#L77-L81
- Fixes tektoncd/website#419, RHDEVDOCS-4312

Signed-off-by: Avinal Kumar <avinal@redhat.com>
@avinal avinal mentioned this issue Aug 8, 2022
Closed
4 tasks
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2022
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 6, 2022
@avinal avinal mentioned this issue Dec 26, 2022
Merged
4 tasks
avinal added a commit to avinal/operator that referenced this issue Dec 26, 2022
@avinal
Define keep and keep-since simultaneously
6760e4a 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974, tektoncd/website#419

Signed-off-by: Avinal Kumar <avinal@redhat.com>
avinal added a commit to avinal/operator that referenced this issue Dec 27, 2022
@avinal
Define keep and keep-since simultaneously
fa22307 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes tektoncd#974, tektoncd/website#419

Signed-off-by: Avinal Kumar <avinal@redhat.com>
tekton-robot pushed a commit to tektoncd/operator that referenced this issue Dec 29, 2022
@avinal @tekton-robot
Define keep and keep-since simultaneously
712ba2d 
- `keep` and `keep-since` can be defined simultaneously in the pruning
configuration.
- the required functionality is already present in the tekton CLI
- add simultaneous annotation to the pruning configuration
- Refer: tektoncd/cli#1471 tektoncd/cli#1533
- Fixes #974, tektoncd/website#419

Signed-off-by: Avinal Kumar <avinal@redhat.com>
@avinal
Copy link
Member

avinal commented Dec 31, 2022

/close Close as completed

@geriom geriom closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
Tekton Community Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add keep-since to TektonConfig docs avinal/operator
5 participants
@fgiloux @geriom @tekton-robot @avinal @sounix000