Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor installation and authentication docs #482

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

geriom
Copy link
Contributor

@geriom geriom commented Nov 28, 2022

Changes

This is the first PR adding vendor-specific documentation.

  • Refactor installation docs to make it simpler with tabs for generic instructions, Google cloud, and Openshift. This is a multi-PR change. The actual installation docs PR #5806 are on the Pipelines repo and rendered on the website.

  • Update the build and push how-to with instructions to authenticate to Google Artifact Registry.

  • Create a new shortcode to commenting out text in the markdown file.

Because this PR depends on two different repos we can't generate a preview automatically. You can preview the new docs here:

Because this PR and PR #5806 depend on one another they must be submitted in short succession.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2022
Copy link
Contributor

@bendory bendory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
I really like the direction this take us toward!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2022
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2023
This is the first PR adding vendor-specific documentation.

- Refactor installation docs to make it simpler with tabs for generic
  instructions, Google cloud, and Openshift. This is a multi-PR change.
  The actual installation doc is created on the Pipelines repo and
  rendered on the website.

- Update the build and push how-to with instructions to authenticate to
  Google Artifact Registry.

- Create a new shortcode to commenting out text in the markdown file.
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geriom !!!
This looks good
/approve
/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, bendory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2023
@tekton-robot tekton-robot merged commit a474765 into tektoncd:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants