-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor installation and authentication docs #482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
I really like the direction this take us toward!
1c884b9
to
ca2c6f0
Compare
This is the first PR adding vendor-specific documentation. - Refactor installation docs to make it simpler with tabs for generic instructions, Google cloud, and Openshift. This is a multi-PR change. The actual installation doc is created on the Pipelines repo and rendered on the website. - Update the build and push how-to with instructions to authenticate to Google Artifact Registry. - Create a new shortcode to commenting out text in the markdown file.
ca2c6f0
to
d53d41b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @geriom !!!
This looks good
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, bendory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This is the first PR adding vendor-specific documentation.
Refactor installation docs to make it simpler with tabs for generic instructions, Google cloud, and Openshift. This is a multi-PR change. The actual installation docs PR #5806 are on the Pipelines repo and rendered on the website.
Update the build and push how-to with instructions to authenticate to Google Artifact Registry.
Create a new shortcode to commenting out text in the markdown file.
Because this PR depends on two different repos we can't generate a preview automatically. You can preview the new docs here:
Because this PR and PR #5806 depend on one another they must be submitted in short succession.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.