Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect /predicate/chains to Chains documentation. #562

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Aug 31, 2023

Changes

This sets up a redirect so for /predicate/chains to Chains documentation.

i.e. https://tekton.dev/predicate/chains/slsa/v2 -> https://github.com/tektoncd/chains/tree/main/docs/predicate/slsa/v2
(these pages don't actually exist yet).

This is a placeholder for SLSA predicate type documentation. We may try to figure out how to handle these better with the doc import process later on, but we need these to keep URL structure that AFAIK sync.py doesn't support well today. These URLs show up in Chains-generated SLSA predicates.

We do not need navigation for these URLs (we'll figure out if we want to add this later with the doc syncing).

See tektoncd/chains#906 for more details.

Fixes #561

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2023
This is a placeholder for SLSA predicate type documentation. We may try
to figure out how to handle these better with the doc import process
later on, but we need these to keep URL structure that AFAIK sync.py doesn't
support well today.
@wlynch
Copy link
Member Author

wlynch commented Oct 5, 2023

@geriom @popcor255 ping for review 🙏 (or let me know if there's someone else I should get to review this)

Copy link
Contributor

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for creating a _redirecs file instead of adding the redirects to netlify.toml?

Either is fine with me, just wondering if one is better than the other.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geriom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@wlynch
Copy link
Member Author

wlynch commented Oct 11, 2023

Is there a reason for creating a _redirecs file instead of adding the redirects to netlify.toml?

Nope, no particular reason. We can rewrite this in netlify.toml if we want. 🤷

@geriom
Copy link
Contributor

geriom commented Oct 11, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@tekton-robot tekton-robot merged commit e94f034 into tektoncd:main Oct 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New endpoint: https://tekton.dev/slsa-predicate
3 participants