-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboard sync config #90
Conversation
Deploy request for tekton pending review. Review with commit 6ca4340 |
@steveodonovan @a-roberts fyi, first step to getting more dashboard content on the website and cleaning up our docs. |
/kind documentation |
Looks all good here /lgtm (I'll be impressed if my lgtm here counts from a Prow perspective 😄 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, the only concern I have is the tag that we are pulling here.
That said we may be using master for other repos too, but that's something we need to fix!
sync/config/dashboard.yaml
Outdated
# latest version of contents. | ||
tags: | ||
# The name of the tag in the GitHub repository. | ||
- name: master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pull the latest released version instead of master here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're pulling master for the other projects already so I went for consistency here. It looks like there's some rudimentary support for multiple versions baked in but it just links to the project repo rather than hosting the versioned docs on the website.
We should discuss this at the docs working group and maybe the broader group too to agree a proper strategy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to add this after the call...
Discussed this at the docs working group on April 22nd. With our current approach, switching the sync script to pull specific release tags instead of master means we wouldn't be able to publish updated docs between releases.
Options:
- patch version releases for doc updates if needed
- change sync script to be more flexible (what would the strategy be?)
- ???
Also discussed current support for multiple versions:
- Items under 'Previous Releases' not obviously clickable at first glance
- clicking 'Archived Versions' brings user to the project repo's 'Tags' page, not obvious how to get to desired docs from there unless familiar with the project structure (select relevant tag, find docs folder, find correct file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afrittoli @AlanGreene PR I think this will give us the flexibility we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to pull v0.6.1.4 as the default, with master
listed under 'Previous releases' (maybe we should rename that section to 'Other versions' or something?)
We've added the initial `_index.md` file from the Dashboard docs to the Dashboard repo, so adding the repo to the sync config.
6ca4340
to
78f59fc
Compare
@popcor255 once we resolve #130 this PR should be good to go. I'll add some details to the issue about navigation from the 'vault' view back to the main docs experience and we can decide what we want to do to improve it before enabling multiple versions. |
/lgtm |
/assign @sbwsg @vdemeester |
/hold |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@AlanGreene what is the status ? 📦 |
There are a number of issues with the current sync approach:
@wlynch has a proposal in #140 to give more direct control to the individual projects that will help to solve many of these. I'm going to close this PR and we can revisit after #140 unless there's an urgent need to surface more Dashboard docs on the website. |
Changes
tektoncd/dashboard#1215
We've added the initial
_index.md
file from the Dashboard docsto the Dashboard repo, so adding the repo to the sync config.
Waiting for tektoncd/dashboard#1268 to be merged first.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.