Update URI.hs #11
Merged
Update URI.hs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote Int instance for URIDecode. Needed this to get the updated README example to compile (as it uses a path segment).
|
Let's land this, thanks! We probably could also use tests here. In particular, I think we need to check to see if there are any leftovers instead of just taking the |
|
See here for more: fc858bf |
|
Makes sense. I knew there could be left overs but wasn't sure how pedantic decoders should be. |
|
Yeah—the policy should probably be to have them be fairly pedantic. Without it we might have awkwardness around matches causing accidental overlap in paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote Int instance for URIDecode. Needed this to get the updated README example to compile (as it uses a path segment).