Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo] Refactor the repo in a per agent fashion #864

Closed
frbattid opened this issue Mar 11, 2016 · 5 comments
Closed

[repo] Refactor the repo in a per agent fashion #864

frbattid opened this issue Mar 11, 2016 · 5 comments
Assignees
@frbattid
Labels
backlog
Milestone
release/1.0.0

Comments

@frbattid
Copy link
Member

The repo must be refactored in a per agent fashion. Current existing development will considered the NGSI agent, and will be re-located under ngsi/ containing its own doc/, conf/, test/ and src/. Then other agents could be addded by internal/external contributors.

  • fiware-cygnus/
    • common/
      • doc/
      • conf/
      • test/
      • src/
    • ngsi/
      • doc/
      • conf/
      • test/
      • src/
    • utool/
      • doc/
      • conf/
      • test/
      • src/
    • other

Still thinking how to proceed (in the long term) with the releasing mechanisms, i.e. docker/ and neore/ folders. In the short/mid term, the NGSI agent will still handling its own specific stuff.
@frbattid frbattid added this to the release/0.14.0 milestone Mar 14, 2016
@frbattid frbattid self-assigned this Mar 14, 2016
@frbattid
Copy link
Member Author

Regarding the common folder, this should include the following code:

  • Backends, which must be as generic purpose as possible, in order to serve all the different agent sinks.
  • Cygnus channels allowing for statistics retrieving.
  • Errors classes.
  • Logging facilities.

@javipalanca
Copy link
Contributor

Great. Waiting for this refactor to include our agent. Btw, since our agent is a generic agent to retrieve tweets, maybe "utool" is not an appropriate name. I suggest "twitter" or "sna" (for social network analysis).

@frbattid
Copy link
Member Author

This must imply the creation of tags per agent. Then, each issue may be labeded.

@frbattid
Copy link
Member Author

Another advantage of this refactor is new agents can be created as context adapters.

@frbattid frbattid modified the milestones: release/0.15.0, release/0.14.0 Mar 17, 2016
@frbattid frbattid modified the milestones: release/0.14.0, release/0.15.0 Apr 5, 2016
@frbattid frbattid mentioned this issue Apr 11, 2016
Merged
@frbattid
Copy link
Member Author

frbattid commented Apr 11, 2016 •
edited

Partially implemented in PR #941 (folder refactoring)
Partially implemented in PR #942 (ignore folder)
Partially implemented in PR #944 (main README)
Partially implemented in PR #943 (contributing guidelines)
Partially implemented in PR #948 (abstract classes)
Partially implemented in PR #949 (documentation)
Partially implemented in PR #951 (RPM scripts)
Partially implemented in PR #955 (install from sources)
Partially implemented in PR #959 (deployers, logs and alarms)
Partially implemented in PR #960 (agent name in logs)
Partially implemented in PR #961 (configuration)
Partially implemented in PR #963 (utils)
Partially implemented in PR #964 (RPM fix)
Partially implemented in PR #965 (constants)
Partially implemented in PR #967 (doc name fixes)
Partially implemented in PR #968 (version trace)
Partially implemented in PR #970 (pom)
Partially implemented in PR #978 (another RPM fix)
Partially implemented in PR #981 (cygnus-common doc)
Partially implemented in PR #991 (contribution guidelines update)
Partially implemented in PR #990 (per-spec RPM)

This was referenced Apr 11, 2016
Merged
Merged
Merged
Merged
Merged
@vgarciag vgarciag mentioned this issue Apr 15, 2016
Merged
frbattid added a commit that referenced this issue Apr 19, 2016
@frbattid
[#864] [cygnus-ngsi] [pom.xml] Add cygnus-common as dependency, and v…
7fc47a0 
…ersion 2.6 for maven assembly plugin
frbattid added a commit that referenced this issue Apr 19, 2016
@frbattid
[#864] [cygnus-ngsi] [install_from_sources.md] Update after the multi…
a918256 
…-agent refactor
@frbattid frbattid mentioned this issue Apr 19, 2016
Merged
frbattid added a commit that referenced this issue Apr 19, 2016
@frbattid
[#864] [cygnus-ngsi] [install_from_sources.md] Add 'Known issues' sec…
550aa51 
…tion
frbattid added a commit that referenced this issue Apr 19, 2016
@frbattid
[#864] [cygnus-ngsi] [install_from_sources.md] Fix issues raised duri…
626cdcc 
…ng code review
frbattid added a commit that referenced this issue Apr 21, 2016
@frbattid
[#864] [cygnus] [contributing_guidelines.md] Add deployers, logs and …
38355e9 
…alarms sections, and reorder the index
@frbattid frbattid mentioned this issue Apr 21, 2016
Merged
frbattid added a commit that referenced this issue Apr 21, 2016
@frbattid
[#864] [cygnus] [contributing_guidelines.md] Fix the layout log4j
6222ce0
frbattid added a commit that referenced this issue Apr 22, 2016
@frbattid
[#864] [cygnus-common] [CommonConstants.java] Rename from Constants.j…
1e4dfd9 
…ava, add LOG4J_COMP
frbattid added a commit that referenced this issue Apr 22, 2016
@frbattid
[#864] [cygnus-ngsi] [NGSIGroupingInterceptor.java, NGSISink.java] Up…
730fa7c 
…date after CommonConstants renaming
frbattid added a commit that referenced this issue Apr 22, 2016
@frbattid
[#864] [cygnus-common] [CKANBackendImpl.java, HttpClientFactory.java,…
7d63d1b 
… CygnusApplication.java] Update after CommonConstants renaming
frbattid added a commit that referenced this issue Apr 28, 2016
@frbattid
[#864][cygnus-ngsi][pom.xml]Remove unnecessary dependencies
b3ef86a
frbattid added a commit that referenced this issue Apr 28, 2016
@frbattid
[#864][cygnus-common][pom.xml]Remove unnecessary dependencies
88be30c
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue Apr 28, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][test]Firsts tests for TwitterHDFSS…
f0ae695 
…ink and TwitterSource.
@vgarciag vgarciag mentioned this issue Apr 29, 2016
Merged
@frbattid frbattid mentioned this issue May 3, 2016
Merged
@vgarciag vgarciag mentioned this issue May 4, 2016
Merged
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 4, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][sinks]Added TwitterSink and Twitte…
097ea2c 
…rHDFSSink. Tweets are stored in rows (each tweet in a line).
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 4, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][test]Fixed TwitterHDFSSinkTest.
f360da7
@frbattid frbattid mentioned this issue May 4, 2016
Merged
@frbattid frbattid closed this as completed May 5, 2016
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 9, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][source] Added TwitterSource to the…
915116e 
… twitter agent. Also included an example of conf file and some tests.
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 9, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][docker]Docker support.
cba39f7
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 9, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][doc]Added User and programmer guide.
0cd737c
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][sources]Improved logging in Twitte…
fab1b59 
…rSource. Fixed typo in docker conf file.
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][doc]Fixed typos in programmers guide.
945457b
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][docker]Updated cygnus-common versi…
5262f46 
…on to 1.0.0.
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][sources]Improved logging.
3c6fbbe
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][sources]Fixed null pointer exception.
ab0ac1f
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][sources]Bounding box coordinates a…
e32d629 
…re now south-west and north-east instead of top-left and bottom-right.
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][sources]sample command removed.
0c13f97
edelval pushed a commit to edelval/fiware-cygnus that referenced this issue May 10, 2016
@elenadvn
[telefonicaid#864][cygnus-twitter][doc] Readme added and user and pro…
f9ca516 
…grammer guide updated
@edelval edelval mentioned this issue May 10, 2016
Merged
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
Merge pull request #1 from edelval/develop
a823dab 
[telefonicaid#864][cygnus-twitter][doc] Readme added and user and programmer guide
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][doc]Fixed typos in README.
ad9b93e
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 10, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][doc]Fixed minor typo in README.
409b851
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 11, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][sinks]Simplified log for TwitterHD…
5a24d35 
…FSSink.
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 11, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][doc]Fixed hdfs_username doc.
646af20
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 11, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][sink]data aggregation trimmed.
5787594
javipalanca added a commit to javipalanca/fiware-cygnus that referenced this issue May 11, 2016
@javipalanca
[telefonicaid#864][cygnus-twitter][source]Replaced deprecated class b…
7a1f906 
…y TwitterObjectFactory.
@frbattid frbattid mentioned this issue May 23, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frbattid frbattid

Labels
backlog
Projects
None yet
Milestone
release/1.0.0
Development

No branches or pull requests
2 participants
@javipalanca @frbattid