Fix/sql backend destination #2007
Conversation
|
A CNR update is needed |
| @@ -34,37 +34,38 @@ | |||
|
|
|||
| /** | |||
| * Creates a table, given its name, if not exists in the given database. | |||
| * @param destination | |||
| * @param dataBase | |||
| * @param tableName | |||
| * @param tableName | ||
| * @param maxRecords | ||
| * @throws com.telefonica.iot.cygnus.errors.CygnusRuntimeError | ||
| * @throws com.telefonica.iot.cygnus.errors.CygnusPersistenceError | ||
| */ | ||
| void capRecords(String destination, String tableName, long maxRecords) throws CygnusRuntimeError, CygnusPersistenceError; | ||
| void capRecords(String dataBase, String tableName, long maxRecords) throws CygnusRuntimeError, CygnusPersistenceError; |
There was a problem hiding this comment.
This method is only implemented by MySQL sink, That's why I didn't add the schema param. Do you thing It should be included?
|
Still duplicated sentence: |
Fixed in fc4f58a |
| @@ -0,0 +1,18 @@ | |||
| package com.telefonica.iot.cygnus.backends.sql; | |||
There was a problem hiding this comment.
License header in all new files, pls :)
IvanHdzC
changed the title
| [cygnus-ngsi] [PostgisSink] Fix PostgreSQL encoding when enabled. | ||
| [cygnus-ngsi] [MysqlSink, PostgisSink, PosgreSQLSink] Update sinks to initialize persistance backend objects without database. (#2004) | ||
| [cygnus-common] Remove database initialization on constructors. (#2004) |
There was a problem hiding this comment.
This PR has no any impact in documentation?
Just to check...
There was a problem hiding this comment.
It's just a bugfix, do not introduce a new behavior
| if (buildDBName(null) != null) { | ||
| createPersistenceBackend(postgisHost, postgisPort, postgisUsername, postgisPassword, maxPoolSize, buildDBName(null), postgisOptions); | ||
| } | ||
| createPersistenceBackend(postgisHost, postgisPort, postgisUsername, postgisPassword, maxPoolSize, postgisOptions); |
There was a problem hiding this comment.
Note that ngsi-ld sinks like this are not fully aligned with ngsiv2 sinks and maybe are not received latest features, bugfixes and refactors.
|
@anmunoz this PR fixes some sinks in cygnus-ngsi that also are being used in cygnus-ngsi-ld. I'm telling you, just in case you want also to apply similar fixes to them. |
fix for #2004
You can find test results on the attached files.
agent.txt
cygnus.txt