feature/320_die_if_no_logs #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frbattid
commented
Mar 5, 2015
frbattid
commented
- Implements issue https://github.com/telefonicaid/fiware-connectors/issues/320
- Fixes issue https://github.com/telefonicaid/fiware-connectors/issues/302
- 100% unit tests passed
- (Unofficial) e2e tests passed (emulating a persistence error, ttl=2)
- Ths PR must be twined into develop
- Assignee: @fgalan , but LGTM from @gtorodelvalle is also required
added 9 commits
February 17, 2015 16:40
| info("[" + componentName + "] " + message); | ||
| } catch (Exception e) { | ||
| if (shutdown) { | ||
| System.err.println("A problem with the logging system was found... shutting down Cygnus right now!"); |
There was a problem hiding this comment.
Maybe you should also print the Exception trace/information to provide more information to the administrator reading the mesage?
There was a problem hiding this comment.
|
Sorry for commenting on the commits :( I left-click-opened them and start commenting there :( I will comment on the pull request "File changed" tab from now on ;) Anyhow, I think all my comments are included so LGTM on my side ;) Thanks @frbattid ;) |
added 2 commits
March 16, 2015 12:17
Conflicts: flume/CHANGES_NEXT_RELEASE flume/src/main/java/es/tid/fiware/fiwareconnectors/cygnus/sinks/OrionSink.java
|
Please ignore the following commits:
|
added 4 commits
March 17, 2015 16:18
Conflicts: flume/CHANGES_NEXT_RELEASE flume/src/main/java/es/tid/fiware/fiwareconnectors/cygnus/nodes/CygnusApplication.java
|
LGTM (Although @gtorodelvalle also told LGTM, not sure if I should merge, given the 8 commits since that point. If you want me to merge, just tell me). |
gtorodelvalle
added a commit
that referenced
this pull request
Mar 18, 2015
feature/320_die_if_no_logs
This was referenced Mar 18, 2015
gtorodelvalle
added a commit
that referenced
this pull request
Dec 1, 2015
feature/320_die_if_no_logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.