hardening/326_libthrift_issue_fix_from_pom_xml #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,8 +62,6 @@ Apache Flume can be easily installed by downloading its latests version from [fl | |||
| $ mv apache-flume-1.4.0-bin APACHE_FLUME_HOME | |||
| $ mv APACHE_FLUME_HOME/lib/httpclient-4.2.1.jar APACHE_FLUME_HOME/lib/httpclient-4.2.1.jar.old | |||
| $ mv APACHE_FLUME_HOME/lib/httpcore-4.2.1.jar APACHE_FLUME_HOME/lib/httpcore-4.2.1.jar.old | |||
| $ wget http://repo1.maven.org/maven2/org/apache/thrift/libthrift/0.9.1/libthrift-0.9.1.jar -P APACHE_FLUME_HOME/lib | |||
| $ mv APACHE_FLUME_HOME/lib/libthrift-0.7.0.jar APACHE_FLUME_HOME/lib/libthrift-0.7.0.jar.old | |||
There was a problem hiding this comment.
This mv command is necessary. Just think this is the manual installation, if we don't rename the old libthrift library, nobody will do that.
|
CHANGES_NEXT_RELEASE update is missing. |
|
CHANGES_NEXT_RELEASE updated in 4374a6b |
|
LGTM, passing the ball to @vgarciag |
frbattid
changed the title
|
LGTM |
vgarciag
added a commit
that referenced
this pull request
Jan 18, 2016
…ue_fix_from_pom_xml hardening/326_libthrift_issue_fix_from_pom_xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked my installation path, in
/usr/cygnus/libwherelibthrift-0.7.0.oldhas the .old extension andlibthrift-0.9.1.jardoesn't appear due to it's included in the .jar filecygnus-0.11.0-jar-with-dependencies.jar