Feature/claudia_5427 Adding management of version in glancesync component #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| current_version = 1.0.0 | ||
| commit = True | ||
| tag = True | ||
|
|
There was a problem hiding this comment.
We prefer not creating tags when bumping a new version, as this operation is performed at the very beginning of a new development sprint, just after previous version is tagged and released from master branch. So please set tag to False.
|
LGTM |
1 similar comment
|
LGTM |
jframos
added a commit
that referenced
this pull request
Sep 29, 2015
Feature/claudia_5427 Adding management of version in glancesync component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
@jframos, @pratid , @chemaper
Description
Testing
No test.