fix sorrt by name when list users, groups, roles

telefonicaid · Feb 15, 2024 · c241703 · c241703
1 parent c323114
commit c241703
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/keystone_scim/contrib/scim/scim.py b/keystone_scim/contrib/scim/scim.py
@@ -135,6 +135,7 @@ def _list_users(self):
         domain = self._get_domain_id_for_list_request()
         refs = PROVIDERS.identity_api.list_users(
             domain_scope=domain, hints=hints)
+        refs.sort(key=lambda d: d['name'])
         scim_page_info = get_scim_page_info(hints)
         # Fix bug retrieving from LDAP which not uses decorete_core_limit and then no scim info in in hints
         if "totalResults" in scim_page_info and scim_page_info['totalResults'] == 0 and len(refs) > 0:
@@ -233,6 +234,7 @@ def _list_roles(self):
         ENFORCER.enforce_call(action='identity:list_roles',
                               filters=filters)
         refs = PROVIDERS.role_api.list_roles(hints=pagination(hints))
+        refs.sort(key=lambda d: d['name'])
         scim_page_info = get_scim_page_info(hints)
         # Fix bug retrieving from LDAP which not uses decorete_core_limit and then no scim info in in hints
         if "totalResults" in scim_page_info and scim_page_info['totalResults'] == 0 and len(refs) > 0:
@@ -398,6 +400,7 @@ def _list_groups(self):
                               target_attr=target)
         refs = PROVIDERS.identity_api.list_groups(
             domain_scope=domain, hints=hints)
+        refs.sort(key=lambda d: d['name'])
         scim_page_info = get_scim_page_info(hints)
         # Fix bug retrieving from LDAP which not uses decorete_core_limit and then no scim info in in hints
         if "totalResults" in scim_page_info and scim_page_info['totalResults'] == 0 and len(refs) > 0: