Merge pull request #65 from telefonicaid/hardening/unit_tests_ngsi

Hardening/unit tests ngsi
telefonicaid · Nov 7, 2013 · e6e2d2c · e6e2d2c
2 parents 89b5253 + 6fc859b
commit e6e2d2c
Show file tree

Hide file tree

Showing 5 changed files with 72 additions and 0 deletions.
diff --git a/test/unittests/ngsi/AttributeAssociationList_test.cpp b/test/unittests/ngsi/AttributeAssociationList_test.cpp
@@ -61,5 +61,31 @@ TEST(AttributeAssociationList, ok)
 
   // Just to exercise the code ...
   aal.present("");
+}
+
+
+
+/* ****************************************************************************
+*
+* invalidAttributeAssociation - 
+*/
+TEST(AttributeAssociationList, invalidAttributeAssociation)
+{
+  AttributeAssociationList aal;
+  AttributeAssociation     aa;
+  std::string              out;
+  std::string              expected1 = "empty target";
+  std::string              expected2 = "empty source";
+
+  aa.source = "S";
+  aa.target = "";
+
+  aal.push_back(&aa);
+  out = aal.check(RegisterContext, XML, "", "", 0);
+  EXPECT_EQ(expected1, out);
 
+  aa.source = "";
+  aa.target = "T";
+  out = aal.check(RegisterContext, XML, "", "", 0);
+  EXPECT_EQ(expected2, out);
 }
diff --git a/test/unittests/ngsi/ContextAttribute_test.cpp b/test/unittests/ngsi/ContextAttribute_test.cpp
@@ -113,3 +113,22 @@ TEST(ContextAttribute, present)
 
   ca.present("", 0);
 }
+
+
+
+/* ****************************************************************************
+*
+* copyMetadatas - 
+*/
+TEST(ContextAttribute, copyMetadatas)
+{
+  ContextAttribute  ca;
+  Metadata          m1("m1", "int", "2");
+  Metadata          m2("m2", "string", "sss");
+
+  ca.metadataVector.push_back(&m1);
+  ca.metadataVector.push_back(&m2);
+
+  ContextAttribute ca2(&ca);
+  EXPECT_EQ(2, ca2.metadataVector.size());
+}
diff --git a/test/unittests/ngsi/ErrorCode_test.cpp b/test/unittests/ngsi/ErrorCode_test.cpp
@@ -57,13 +57,18 @@ TEST(ErrorCode, check)
 {
   ErrorCode    e1(0, "REASON", "DETAILS");
   ErrorCode    e2(200, "", "DETAILS");
+  ErrorCode    e3(200, "REASON", "DETAILS");
   std::string  rendered;
   std::string  expected1 = "no code";
   std::string  expected2 = "no reason phrase";
+  std::string  expected3 = "OK";
 
   rendered = e1.check(RegisterContext, XML, "", "", 0);
   EXPECT_STREQ(expected1.c_str(), rendered.c_str());
 
   rendered = e2.check(RegisterContext, XML, "", "", 0);
   EXPECT_STREQ(expected2.c_str(), rendered.c_str());
+
+  rendered = e3.check(RegisterContext, XML, "", "", 0);
+  EXPECT_STREQ(expected3.c_str(), rendered.c_str());
 }
diff --git a/test/unittests/ngsi/Metadata_test.cpp b/test/unittests/ngsi/Metadata_test.cpp
@@ -28,6 +28,23 @@
 
 
 
+/* ****************************************************************************
+*
+* constructor - 
+*/
+TEST(Metadata, constructor)
+{
+   Metadata m1;
+   Metadata m2("n2", "t2", "v2");
+   Metadata m3(&m2);
+
+   EXPECT_EQ("", m1.name);
+   EXPECT_EQ("n2", m2.name);
+   EXPECT_EQ("n2", m3.name);
+}
+
+
+
 /* ****************************************************************************
 *
 * render - 

diff --git a/test/unittests/ngsi/Request_test.cpp b/test/unittests/ngsi/Request_test.cpp
@@ -69,7 +69,9 @@ TEST(Request, requestType)
     { UpdateContextAttribute,                    "UpdateContextAttribute"                                 },
     { LogRequest,                                "Log"                                                    },
     { VersionRequest,                            "Version"                                                },
+    { StatisticsRequest,                         "Statistics"                                             },
     { ExitRequest,                               "Exit"                                                   },
+    { LeakRequest,                               "Leak"                                                   },
     { InvalidRequest,                            "InvalidRequest"                                         },
     { RegisterResponse,                          "RegisterResponse"                                       }
   };
@@ -78,4 +80,7 @@ TEST(Request, requestType)
   {
     EXPECT_STREQ(req[ix].string, requestType(req[ix].rt));
   }
+
+  RequestType rt = (RequestType) (RegisterResponse + 1);
+  EXPECT_STREQ("", requestType(rt));
 }