Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserved characters in payload #209

Closed
kzangeli opened this issue Jan 31, 2014 · 8 comments
Closed

Reserved characters in payload #209

kzangeli opened this issue Jan 31, 2014 · 8 comments

Comments

@kzangeli
Copy link
Member

Description

We need to escape all reserved characters in the payload.

This issue will need some discussion before implementing.

Effort: 5 man day

@kzangeli
Copy link
Member Author

A temptative list of JSON chars to escape:

\" Standard JSON quote
\\ Backslash (Escape char)
\/ Forward slash
\b Backspace (ascii code 08)
\f Form feed (ascii code 0C)
\n Newline
\r Carriage return
\t Horizontal Tab
\u four-hex-digits

And XML:

>   (Greater than)     >
<   (Less than)        &lt;
&   (Ampersand)        &amp;
%   (Percent)          &#37;
'   (Single Quote)     &apos;
"   (Double Quote)     &quot;

@fgalan
Copy link
Member

fgalan commented May 7, 2014

Ups, sorry for the early close... wrong click in the github interface :$

@fgalan
Copy link
Member

fgalan commented May 7, 2014

In http://www.w3schools.com/xml/xml_syntax.asp the "%" is not mentioned as forbidden character in XML...

@kzangeli
Copy link
Member Author

kzangeli commented May 7, 2014

There are many lists out there on what must be escaped and not.
The one that starts with this issue (or all of us) will have to do some investigation.

@fgalan
Copy link
Member

fgalan commented May 7, 2014

The "final word" would be in the XML specification itself... but it could be a nightmare review that document.

@kzangeli
Copy link
Member Author

kzangeli commented May 7, 2014

Yeah, but not only.
We need the ones for JSON as well, and escape all these chars before storing in mongo and perhaps unescape differently depending on whether the response is in JSON or XML.
As I mentioned, this is not trivial.

@fgalan
Copy link
Member

fgalan commented Oct 29, 2014

Increase importance level to MUST (after realizing this issue may be related with cross-scripting)

@fgalan fgalan added must and removed P8 should labels Oct 29, 2014
@fgalan
Copy link
Member

fgalan commented Nov 5, 2014

This issue is being closed in favour of #619

@fgalan fgalan closed this as completed Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants