in POST v2/op/update, if we use an unknown action the op is successful

[iariasleon]

in POST v2/op/update, if we use an unknown action "actionType": "dfgdf" the op is successfully

update bach operation request

POST localhost:1026/v2/op/update
headers:
    Content-Type: application/json
    Fiware-Service: test_op_update_happy_path
    Fiware-ServicePath: /test
payload: {"entities": [{"type": "house", "temperature": {"value": "34"}, "id": "room1_0"}, {"type": "house", "temperature": {"value": "34"}, "id": "room1_1"}, {"type": "house", "temperature": {"value": "34"}, "id": "room1_2"}, {"type": "house", "temperature": {"value": "34"}, "id": "room1_3"}, {"type": "house", "temperature": {"value": "34"}, "id": "room1_4"}], "actionType": "dfgdf"}

update bach operation response

http code: 204 - No Content
headers:
   Connection: Keep-Alive
   Content-Length: 0
   Fiware-Correlator: 84769862-a766-11e6-98a0-005056a20feb
   Date: Thu, 10 Nov 2016 16:55:43 GMT
payload:

docs in mongo

{ "_id" : { "id" : "room1_0", "type" : "house", "servicePath" : "/test" }, "attrNames" : [ "temperature" ], "attrs" : { "temperature" : { "type" : "Text", "creDate" : 1478797236, "modDate" : 1478797236, "value" : "34", "mdNames" : [ ] } }, "creDate" : 1478797236, "modDate" : 1478797236 }
{ "_id" : { "id" : "room1_1", "type" : "house", "servicePath" : "/test" }, "attrNames" : [ "temperature" ], "attrs" : { "temperature" : { "type" : "Text", "creDate" : 1478797236, "modDate" : 1478797236, "value" : "34", "mdNames" : [ ] } }, "creDate" : 1478797236, "modDate" : 1478797236 }
{ "_id" : { "id" : "room1_2", "type" : "house", "servicePath" : "/test" }, "attrNames" : [ "temperature" ], "attrs" : { "temperature" : { "type" : "Text", "creDate" : 1478797236, "modDate" : 1478797236, "value" : "34", "mdNames" : [ ] } }, "creDate" : 1478797236, "modDate" : 1478797236 }
{ "_id" : { "id" : "room1_3", "type" : "house", "servicePath" : "/test" }, "attrNames" : [ "temperature" ], "attrs" : { "temperature" : { "type" : "Text", "creDate" : 1478797236, "modDate" : 1478797236, "value" : "34", "mdNames" : [ ] } }, "creDate" : 1478797236, "modDate" : 1478797236 }
{ "_id" : { "id" : "room1_4", "type" : "house", "servicePath" : "/test" }, "attrNames" : [ "temperature" ], "attrs" : { "temperature" : { "type" : "Text", "creDate" : 1478797236, "modDate" : 1478797236, "value" : "34", "mdNames" : [ ] } }, "creDate" : 1478797236, "modDate" : 1478797236 }

[fgalan]

So you mean that wrong actionType is interpreted as APPEND. Is that correct?

[iariasleon]

Yes, with wrong actionType, APPEND is the operation assumed . Also con "" (empty), not plain ascii and forbidden chars, returning 204 as http code.

[fgalan]

Fixed by PR #2679.

[fgalan]

(Reopened, as github automagically closed it)

[iariasleon]

If the actionType is equals to house"flat", the response is a wrong json, ex:

{"error":"BadRequest","description":"invalid update action type: /house"flat"/"}

tested with the CB version:

  "version" : "1.5.0-next"
  "git_hash" : "1ac05a02f0a1b2a1de88ecc58b452c6139db0b8c"

[fgalan]

Fixed in #2700. Ready for re-test @iariasleon , pls.

[iariasleon]

LGTM

http code: 400 - Bad Request
headers:
   Connection: Keep-Alive
   Content-Length: 129
   Content-Type: application/json
   Fiware-Correlator: e3b512a8-b0d1-11e6-a22b-005056a20feb
   Date: Tue, 22 Nov 2016 16:36:59 GMT
payload: {"error":"BadRequest","description":"invalid update action type: right ones are: APPEND, APPEND_STRICT, DELETE, REPLACE, UPDATE"}