-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible stack overflow in APIv1 in boost jsonParser dependency #3607
Comments
As I was told the APIv1 is close to being fully deprecated, hence the APIv1 related issues may not be super urgent anymore. However, I noticed there seem to be similar problems in both endpoints. Hence the APIv1 issues may still be useful for comparison/testing. |
Thanks for the feedback! Could you confirm which endpoints (verb + URL) are you using in test cases 1, 2 and 3, please? |
Hi, sorry for the delay. For all the request on the APIv1 the following request structure was used: headers = {"Content-type": "application/json", "Accept": "application/json"}
return requests.post(
f"http://localhost:1026/v1/updateContext",
headers=headers,
data=self.last_request.encode("utf-8")
) |
I have been unable to reproduce this problem. Moreover, PR #3615 adds test cases covering the cases in the issue (although I haven't got so far explicit confirmation, I could have made some mistake imitating the same cases). I'm closing the issue given that, under my perspective, there is nothing else we can do. Of course, if we receive more feedback from @0xricksanchez and new actions have to be taken, the issue could be reopened. |
Check my reasoning in #3603
Sending malformed JSON entities to the context.Orion_LD (compiled with an Address Sanitizer) V1 API can result in a stack overflow in the
/boost/property_tree/json_parser
:It looks like our JSON request was deemed valid from the FIWARE side of things but the format breaks the
Ptree()
implementation in the boost library, which provides a JSON parser utility./boost/property_tree/json_parser/detail/standard_callbacks.hpp:123
Crash back trace:
Recorded responsible test case 1 :
Recorded responsible test case 2:
Can be found here
Recorded responsible test case 3:
Can be found here
The text was updated successfully, but these errors were encountered: