FIX illegal JSON in attributeFormat=object mode #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| break; | ||
|
|
||
| case ValueTypeNone: | ||
| effectiveValue = "null"; | ||
| withoutQuotes = true; |
There was a problem hiding this comment.
I could have used valueIsNumberOrBoolOrNull but that's too much, so I opted for withoutQuotes.
There was a problem hiding this comment.
withoutQuotes is ok.
isString (the negation) would be ok as well (I guess).
NTC
|
LGTM, but merge with develop needed |
fgalan
force-pushed
the
bug/2058_ilegal_json_attributeformat_object_with_numbers
branch
from
7bdbf4d
to
c8b1840
Compare
| --SHELL-- | ||
|
|
||
| # | ||
| # 01. Create entity with not string types |
There was a problem hiding this comment.
not string types ...
types that are not 'string' ?
|
LGTM, again :-) |
|
LGTM |
fgalan
deleted the
bug/2058_ilegal_json_attributeformat_object_with_numbers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2058
@crbrox
@kzangeli