bug/2584_service_path_as_http_header_in_notifications #2828

kzangeli · 2017-01-20T08:42:52Z

Fixed issue #2584.

fgalan · 2017-01-20T08:46:06Z

test/functionalTest/cases/0673_xauth_token/auth_token_from_subscribe_request.test

@@ -192,6 +192,8 @@ Date: REGEX(.*)
 ========================================================================================
 POST http://127.0.0.1:REGEX(\d+)/notify
 Content-Length: 459
+Fiware-Servicepath: /
+Fiware-Servicepath: /


Fixed in deeabf3

fgalan · 2017-01-20T08:46:14Z

test/functionalTest/cases/0673_xauth_token/auth_token_from_subscribe_request.test

@@ -251,6 +253,8 @@ Date: REGEX(.*)
 ==================================================================================================
 POST http://127.0.0.1:REGEX(\d+)/notify
 Content-Length: 459
+Fiware-Servicepath: /
+Fiware-Servicepath: /


Fixed in deeabf3

fgalan · 2017-01-20T08:46:39Z

test/functionalTest/cases/0673_xauth_token/auth_token_three_steps.test

@@ -237,6 +237,8 @@ Date: REGEX(.*)
 ========================================================================================
 POST http://127.0.0.1:REGEX(\d+)/notify
 Content-Length: 459
+Fiware-Servicepath: /
+Fiware-Servicepath: /


Fixed in deeabf3

fgalan · 2017-01-20T08:46:45Z

test/functionalTest/cases/0673_xauth_token/auth_token_three_steps.test

@@ -314,6 +316,8 @@ Date: REGEX(.*)
 ================================================================================
 POST http://127.0.0.1:REGEX(\d+)/notify
 Content-Length: 460
+Fiware-Servicepath: /
+Fiware-Servicepath: /


Fixed in deeabf3

fgalan · 2017-01-20T08:47:01Z

test/functionalTest/cases/0673_xauth_token/subscription.test

@@ -142,6 +142,8 @@ Date: REGEX(.*)
 =============================================================
 POST http://127.0.0.1:REGEX(\d+)/notify
 Content-Length: 459
+Fiware-Servicepath: /
+Fiware-Servicepath: /


Fixed in deeabf3

fgalan · 2017-01-20T08:51:09Z

...ctionalTest/cases/2015_notification_templates/notification_templates_many_notifications.test

@@ -320,6 +323,7 @@ Fiware-Correlator: REGEX([0-9a-f\-]{36})
 =======================================
 POST http://127.0.0.1:REGEX(\d+)/notify
 Fiware-Servicepath: /
+Fiware-Servicepath: /


Fixed in deeabf3

fgalan · 2017-01-20T08:52:21Z

...ctionalTest/cases/2015_notification_templates/notification_templates_many_notifications.test

@@ -346,6 +350,7 @@ Fiware-Correlator: REGEX([0-9a-f\-]{36})
 PUT http://127.0.0.1:REGEX(\d+)/notify?a1=true&type=T1&id=E1
 Fiware-Servicepath: /
 Entity-Id: E1
+Fiware-Servicepath: /


Fixed in deeabf3

This is an example of dup with an already existing "Fiware-Servicpath: /" line

fgalan · 2017-01-20T08:52:26Z

...ctionalTest/cases/2015_notification_templates/notification_templates_many_notifications.test

@@ -365,6 +370,7 @@ Fiware-Correlator: REGEX([0-9a-f\-]{36})
 PUT http://127.0.0.1:REGEX(\d+)/notify?a2=null&type=T2&id=E1
 Fiware-Servicepath: /
 Entity-Id: E1
+Fiware-Servicepath: /


Fixed in deeabf3

This is an example of dup with an already existing "Fiware-Servicpath: /" line

fgalan · 2017-01-20T08:52:29Z

...ctionalTest/cases/2015_notification_templates/notification_templates_many_notifications.test

@@ -385,6 +391,7 @@ PUT http://127.0.0.1:REGEX(\d+)/notify?a3=3&type=T3&id=E1
 Fiware-Servicepath: /
 Ngsiv2-Attrsformat: custom
 Entity-Id: E1
+Fiware-Servicepath: /


Fixed in deeabf3

This is an example of dup with an already existing "Fiware-Servicpath: /" line

fgalan · 2017-01-20T08:54:34Z

test/functionalTest/cases/2584_service_path_header_in_notifs/service_path_header_in_notifs.test

@@ -0,0 +1,196 @@
+# Copyright 2017 Telefonica Investigacion y Desarrollo, S.A.U


Do we really need a new .test for this when the large ammount of notifications in default SP we have in another tests will ensure the functionality is correct? I does't suggest to remove it (as it is already written) just a remark to think twice next time in similar situations ;)

NTC

This is merely a tool that I needed while trying to fix the bug.
And you're right, once the bug is fixed, no need for this test anymore.

And to anticipate :-):
No, it is not easier to try to find a 'half valid' already existing functest than to create a new one.
A new one is both faster and better suited for the problem
To create a functest takes me a few minutes, copying from older functests (as I believe we all do)

A new one is both faster and better suited for the problem

Faster and better in the context of a given isolated problem solution task, but not so fast and good in the overall. Each new .test is another lilttle piece of stuff to mantain (and when you have to do a large refactor effort, e.g. XML removal, these little pieces, all together, have a significative cost). In addition, each new .test is a little more delay in make test, so impacting our development speed (even in the case of "I'm working on the next development while make test ends" part of your mind is still in the PR that you haven't merged yet due to the make test... at least in my case I cannot do complete context change as computers do ;).

It isnt' a golde rule about this, but something to think about (food for thought).

…0000_large_requests/notification_different_sizes.test

…fixed

fgalan · 2017-01-20T09:52:19Z

...ctionalTest/cases/2015_notification_templates/notification_templates_many_notifications.test

@@ -295,6 +297,7 @@ Fiware-Correlator: REGEX([0-9a-f\-]{36})
 =======================================
 POST http://127.0.0.1:REGEX(\d+)/notify
 Fiware-Servicepath: /
+Fiware-Servicepath: /


This is an example of dup with an already existing "Fiware-Servicpath: /" line

fgalan · 2017-01-20T09:52:29Z

...ctionalTest/cases/2015_notification_templates/notification_templates_many_notifications.test

@@ -320,6 +323,7 @@ Fiware-Correlator: REGEX([0-9a-f\-]{36})
 =======================================
 POST http://127.0.0.1:REGEX(\d+)/notify
 Fiware-Servicepath: /
+Fiware-Servicepath: /


This is an example of dup with an already existing "Fiware-Servicpath: /" line

…tifications

fgalan · 2017-01-20T10:48:23Z

LGTM

Fixed issue 2584

7721535

kzangeli added this to the 1.7.0 milestone Jan 20, 2017

kzangeli assigned fgalan Jan 20, 2017

fgalan requested changes Jan 20, 2017

View reviewed changes

Ken Zangelin added 2 commits January 20, 2017 10:24

Removed dups of service-path http header inserted by mistake + fixed …

deeabf3

…0000_large_requests/notification_different_sizes.test

Error in 'forbidden chars' vs 'Invalid characters' ... old error now …

fe4544f

…fixed

fgalan reviewed Jan 20, 2017

View reviewed changes

Ken Zangelin added 3 commits January 20, 2017 11:17

CHANGES_NEXT_RELEASE

e9111ba

CHANGES_NEXT_RELEASE

8c00d0f

Merge branch 'master' into bug/2584_service_path_as_http_header_in_no…

019e5e2

…tifications

fgalan merged commit 54cea66 into master Jan 20, 2017

fgalan deleted the bug/2584_service_path_as_http_header_in_notifications branch January 20, 2017 10:48

fgalan mentioned this pull request Jan 20, 2017

Notifications not including the Fiware-ServicePath header #2584

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug/2584_service_path_as_http_header_in_notifications #2828

bug/2584_service_path_as_http_header_in_notifications #2828

kzangeli commented Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

fgalan Jan 20, 2017

kzangeli Jan 20, 2017

fgalan Jan 20, 2017

fgalan Jan 20, 2017

fgalan Jan 20, 2017

fgalan commented Jan 20, 2017

		@@ -0,0 +1,196 @@
		# Copyright 2017 Telefonica Investigacion y Desarrollo, S.A.U

bug/2584_service_path_as_http_header_in_notifications #2828

bug/2584_service_path_as_http_header_in_notifications #2828

Conversation

kzangeli commented Jan 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fgalan commented Jan 20, 2017