Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: yum repo config #3184

Merged
merged 1 commit into from May 28, 2018
Merged

fix: yum repo config #3184

merged 1 commit into from May 28, 2018

Conversation

caa06d9c
Copy link
Contributor

No description provided.

@caa06d9c caa06d9c mentioned this pull request May 28, 2018
Closed
preetha2711
preetha2711 reviewed May 28, 2018
View reviewed changes
Copy link

@preetha2711 preetha2711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this seems to be working!

fgalan
fgalan reviewed May 28, 2018
View reviewed changes
doc/manuals/admin/yum.md
@@ -16,32 +16,31 @@ Use this configuration for release repository:
```
[fiware-release]
name=FIWARE release repository
baseurl=https://nexus.lab.fiware.org/repository/el/$releasever/$basearch/release
baseurl=https://nexus.lab.fiware.org/repository/el/7/x86_64/release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate a bit? Has been $releaserver and $basearch variables deprecated in recent RHEL/CentOS versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

releasever returns a different values in rh and centos (7Server and 7), so it's better to make it static. basearch alone will require explanation, so it's better to make it static too.
parameters already changed in release.repo and nightly.repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

NTC

fgalan
fgalan approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 4e2f981 into telefonicaid:master May 28, 2018
@caa06d9c caa06d9c deleted the fix_doc_yum branch August 28, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preetha2711 preetha2711 preetha2711 left review comments

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caa06d9c @fgalan @preetha2711