Return 500 when DB is not connected (fix for issue 570) (prelanding) #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-suggestions Return 500 when DB is not connected - Include suggestions into prelading PR
mapedraza
reviewed
Mar 17, 2022
Co-authored-by: mapedraza <40356341+mapedraza@users.noreply.github.com>
|
End 2 end tests moved to a new different file + deletion of the other tests done in 9f02447 . |
|
Added tests expectations + more descriptive error message in 3df4d63 As an example, the error response is like the following: {"statusCode":500,"error":"Internat Server Error","message":"DB not connected"} |
mapedraza
reviewed
Mar 22, 2022
test/unit/sthE2E_test.js
Outdated
| entityId: 'E', | ||
| attrName: 'A' | ||
| }, | ||
| 'A' // maybe unneeded in API_OPERATION.DELETE case (see getURL method) |
There was a problem hiding this comment.
I already checked that, without this line, tests complete successfully
Suggested change
| 'A' // maybe unneeded in API_OPERATION.DELETE case (see getURL method) |
There was a problem hiding this comment.
The , in L122 should be removed if L123 is removed, shouldn't be?
There was a problem hiding this comment.
Yes, was a typo on the review
fgalan
commented
Mar 22, 2022
fgalan
commented
Mar 22, 2022
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
fgalan
changed the title
fgalan
commented
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #570. Continues the work in PR #574
It can be noted that at PR creation time (at commit 45c2186) PR has +132 -14 in changes, the same as the old PR.
CC: @Gauravp-NEC
To be completed (by @mapedraza )
it('should disconnect from the database', ...)clause is not really a step to test but a preparation statement. It should be done in the "before" clause associated to the containingdescribe()block.