Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the removeAllSubscriptions function #1082

Closed
wants to merge 1 commit into from
Closed

remove the removeAllSubscriptions function #1082

wants to merge 1 commit into from

Conversation

Sunny-NEC
Copy link

pr for the issue #576

@fgalan
Copy link
Member

fgalan commented Aug 26, 2021

Not sure if just removing the code is a proper solution for issue #576... Note this comment in that issue:

If my theory confirms (I may be wrong) it seems that unsubcription code in the library is dead code. As a consecuence, subscriptions are not correctly cleaned up when devices are deleted by API, leaving dirty stuff in CB.

So the solution shouldn't be remove the unsubscription code in the library but using it properly in the user code (IOTA agents code) to clean up subscriptions when devices are deleted so no "zombie" subscription remains at CB after the deletion.

@Sunny-NEC
Copy link
Author

image

@fgalan I did some test but did not find any issue after removing this function.

@fgalan
Copy link
Member

fgalan commented Aug 31, 2021

@fgalan I did some test but did not find any issue after removing this function.

Yes, but that's not the way of solving issue #576 :) The good solution is to properly use that code, not removing it. Please find my detailed comment above.

@Sunny-NEC Sunny-NEC closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants