Task/plugins refactor: alias, expressions, multientity and timestamp plugins #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrutid
reviewed
Mar 2, 2023
fgalan
reviewed
Mar 7, 2023
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
|
@jason-fox This PR is going to be merged soon. A twin PR modifying NGSI-LD equivalent files should be merged before deleting old files and leftovers in #1321, otherwise, NGSI-LD functionality will be broken after merging #1321 |
fgalan
reviewed
Mar 21, 2023
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
This was referenced Mar 21, 2023
This was referenced Mar 22, 2023
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1195
This PR is about alias, expressions, multientity, timestamp plugins. This new implementation allow remove alias, expressions, multientity, timestamp plugins middelwares.
This PR still does not remove old stuff about plugins due ngsi-ld implementation and tests.
Test that were modified:
JSON reordered (but equivalent):
test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin5.json
test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin8.json
test/unit/ngsiv2/examples/contextRequests/updateContextMultientityTimestampPlugin1.json
test/unit/ngsiv2/examples/contextRequests/updateContextMultientityTimestampPlugin2.json
POST [batch 1 entity] -> PATCH [1 entity]
test/unit/ngsiv2/examples/contextRequests/updateContextMultientityTimestampPlugin4.json
REMOVE ATT METADATA timestamp: timestamp is provided ad measure and other tests does not include it
test/unit/ngsiv2/examples/contextRequests/updateContextProcessTimestamp.json
REMOVE empty new multi entities (according with test not all entities are expected!)
test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin6.json
test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin7.json
ADD empty base entity
test/unit/ngsiv2/examples/contextRequests/updateContextMultientityPlugin11.json
The following plugin tests where modified:
This PR also fixes bug telefonicaid/iotagent-json#697 and #1291
Pending tasks (for further PRs?)