Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/static attrs when explicit attrs #1507

Merged
merged 11 commits into from
Oct 10, 2023
Merged

Fix/static attrs when explicit attrs #1507

merged 11 commits into from
Oct 10, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Oct 9, 2023 •
edited
Loading

fix for #1506

  • Doc about explicitAttrs and static attrs should be updated

this PR implements the following behaviour:

Si explicitAttrs=true, No filtra statics

Si explicitAttrs=false, No filtra statics

Si explicitAttrs= expresion o array, si filtra statics (como el resto de atributos)

@AlvaroVega AlvaroVega marked this pull request as ready for review October 9, 2023 11:09
fgalan
fgalan approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan mentioned this pull request Oct 9, 2023
Closed
@AlvaroVega AlvaroVega mentioned this pull request Oct 9, 2023
Closed
mapedraza
mapedraza approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit 90b11d3 into master Oct 10, 2023
8 checks passed
@mapedraza mapedraza deleted the fix/static_attrs_when_explicitAttrs branch October 10, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

@mapedraza mapedraza mapedraza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlvaroVega @fgalan @mapedraza