Task/allow devices same device id in same path but apikey #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalan
reviewed
Apr 3, 2024
fgalan
reviewed
Apr 4, 2024
| has been provisioned with `type=X`/`apiKey=111` and no other config group has been provisioned. | ||
| are identified by a `device_id`, and they are associated to an existing config group based in `apiKey` matching. For | ||
| instance, let's consider a situation in which a config group has been provisioned with `type=X`/`apiKey=111` and no | ||
| other config group has been provisioned. | ||
|
|
||
| The IoT Agents offer a provisioning API where devices can be preregistered, so all the information about service and |
There was a problem hiding this comment.
To make this more explicit, maybe we can add a new sub-section after ### Devices with the following text:
Uniqueness of groups and devices
- Group service uniqueness is defined by the combination of: service, subservice and apiKey
- Device uniqueness is defined by the combination of: service, subservice, device_id and apiKey. Note that the several devices with the same device_id are allowed in the same service and subservice as long as their apiKeys are different.
Please, check, just in case I can be wrong with the above text...
(Btw, it's a bit weird that device_id uses snake_case but apiKey uses camelCase. In the database the MongoDB fields use the same?)
fgalan
reviewed
Apr 4, 2024
fgalan
reviewed
Apr 4, 2024
fgalan
deleted the
task/allow_devices_same_device_id_in_same_path_but_apikey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1589
Related with #1426 #1435) (#1430)