fix timestamp mapped attribute cases #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlvaroVega
changed the title
AlvaroVega
changed the title
|
We should include tests about include also:
|
AlvaroVega
changed the title
mrutid
reviewed
Apr 10, 2024
| return; | ||
| } | ||
| } else { | ||
| if (!typeInformation.timezone) { |
There was a problem hiding this comment.
Maybe this could be precalculated to simplify logic and optimize. Minor.
AlvaroVega
commented
Apr 10, 2024
| jexlctxt[constants.TIMESTAMP_ATTRIBUTE] = timestamp.value; // nosense | ||
| } else { | ||
| timestamp.value = moment().tz(typeInformation.timezone).format('YYYY-MM-DD[T]HH:mm:ss.SSSZ'); | ||
| jexlctxt[constants.TIMESTAMP_ATTRIBUTE] = timestamp.value; // nosense |
There was a problem hiding this comment.
jexlctxt is not used any more from this point
3 tasks
fgalan
reviewed
Apr 17, 2024
fgalan
reviewed
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1557
This PR includes fixes and includes two new cases