Rebase of PR #775 "configGroups" literal in configuration group operations URL #780

Jagatjot · 2019-04-24T07:05:33Z

No description provided.

Jagatjot · 2019-04-24T08:03:53Z

@fgalan This PR is rebased version of #775 which fixes issue #752

fgalan · 2019-04-29T15:04:26Z

lib/services/northBound/deviceGroupAdministrationServer.js

@@ -268,20 +268,40 @@ function loadContextRoutes(router) {
        restUtils.checkRequestAttributes('headers', mandatoryHeaders),
        restUtils.checkBody(templateGroup),
        handleCreateDeviceGroup);
+
+    router.post('/iot/cgroups',


Originally I saw this implemented in a more compact way, i.e. using

router.post('/iot/:services?/:cgroups?'

Why this was changed? It's ok also in the current way, but I'm curious about it...

(Btw, after some internal discussion, we probably would suggest a different literal for the URL? cgroups -> configGroups. However, please wait for confirmation before start doing the changes in the PR).

This was changed to increase the test coverage which was decreased previously. OK will wait for your confirmation whether to keep cgroups or configGroups.

I do confirm the chosen token is configGroups. Thanks!

Fixed at commit e6cee6a

fgalan · 2019-04-29T15:07:06Z

test/unit/general/iotam-autoregistration-test.js

@@ -301,6 +389,41 @@ describe('IoT Manager autoregistration', function() {
            });
        });
    });
+    describe('When a new service is created in the IoT Agent', function() {


I assume that for each new added test for /iot/cgroups there is a test for /iot/services that has been copied and adapter to cover the new URL. Is my assumption correct?

Yes, after adding the new functionality I had to ensure the previous functionality doesn't impact therefore similar test cases for /iot/cgroups are added.

So there is a 1:1 correspondence between the old and the new test, isn't it?

In that case, I'd suggest adding a mark in a comment just above the describe() of the old test with a text like this:

// This test will be removed if at the end the /iot/services API (now deprecated) is removed

Fixed at commit e6cee6a

fgalan · 2019-04-29T15:09:20Z

README.md

@@ -717,7 +717,7 @@ The IoT Agents provide two means to define those device groups:
 -   Static **Type Configuration**: configuring the `ngsi.types` property in the


Please add a line to CHANGES_NEXT_RELEASE about this PR fixes. For instance:

Add: /iot/cgroups API endpoints (as equivalent to /iot/services) (#752)

Fixed by ee0d509

fgalan · 2019-05-22T07:46:48Z

I have realized that some changes in the payload would be needed. I mean the old operation is like this:

POST /iot/services
{
  "services": [
    {
      "apikey": "{{UL_APIKEY}}",
      "entity_type": "device",
      …
      "protocol": [ "IoTA-UL" ]
    }
  ]
}

So the new one should be:

POST /iot/configGroups
{
  "configGroups": [
    {
      "apikey": "{{UL_APIKEY}}",
      "entity_type": "device",
      …
      "protocol": [ "IoTA-UL" ]
    }
  ]
}

But as far as I understand, with the current PR code (cconfig -> configGroups change appart) is like this:

POST /iot/configGroups
{
  "services": [
    {
      "apikey": "{{UL_APIKEY}}",
      "entity_type": "device",
      …
      "protocol": [ "IoTA-UL" ]
    }
  ]
}

I mean, URl is using configGroup and payload uses service. This should be fixed.

(I have put my example with POST, but of course, this applies to other operations, e.g. GET, etc.)

fgalan · 2019-05-30T09:33:49Z

@Jagatjot any update in this PR, please? Don't hesitate of asking if something is not clear about what is pending in this PR to be finished and merged. Thanks!

Jagatjot · 2019-05-31T05:27:25Z

@fgalan Fixed by f90ddfb

fgalan · 2019-06-03T08:48:50Z

CHANGES_NEXT_RELEASE

+Add: support for authentication to NGSI subscription requests (#592) 
+Fix: process dies if reconnection to DB fails instead of remain in a zombie state (#772)
+Add: handlers defined with setConfigurationHandler receive as argument the service, subservice, resource and apikey (#769)
+Add: /iot/configGroups API endpoints (as equivalent to /iot/services) (#752)


Similar to telefonicaid/iotagent-json#400, only the lines corresponding to this PR should be added in this PR. In particular, only this one:

Add: /iot/configGroups API endpoints (as equivalent to /iot/services) (#752)

Fixed. CHANGES_NEXT_RELEASE looks correct at commit e6cee6a

Jagatjot · 2020-06-22T14:51:38Z

Sorry for the delay... I have done a new review and provide a new round of feedback. Thanks for your contribution!

Many of the new comments can be directly applied using the "commit suggestion" button. The PR is progressing and that's good although some changes are required in the tests part.

@fgalan Thank you for review. I have added a new set of implementation and the test cases. Please review and re-run the travis as it didn't ran while executing the commits.

fgalan · 2020-06-22T15:52:18Z

Please review and re-run the travis as it didn't ran while executing the commits.

Please solve conflict on CHANGES_NEXT_RELEASE. Travis doesn't run if the PR has conflicts in place. Once solved, travis will be triggered automatically.

fgalan · 2020-10-07T12:06:16Z

I understand you have closed this PR as you have left FIWARE activities :(

I think it would be a good idea to keep it so your work not get lost and maybe others can continue it in the future. In that line, I have ported this PR to #922. However, if you find this is not appropiated (in the case you want to completely withdraw your work from the repository) please tell me and I will close #922.

Jagatjot · 2020-10-07T12:18:25Z

I understand you have closed this PR as you have left FIWARE activities :(

I think it would be a good idea to keep it so your work not get lost and maybe others can continue it in the future. In that line, I have ported this PR to #922. However, if you find this is not appropiated (in the case you want to completely withdraw your work from the repository) please tell me and I will close #922.

@fgalan It will be fine to keep the PR #922 open as it will not waste the work done till now :)

Jagatjot added 3 commits April 24, 2019 12:30

Update deviceGroupAdministrationServer.js

7d38b0b

Update device-group-api-test.js

3721a6c

Update device-group-utils_test.js

c5ac0ee

Jagatjot changed the title ~~Update deviceGroupAdministrationServer.js~~ Rebase of PR https://github.com/telefonicaid/iotagent-node-lib/pull/775 Apr 24, 2019

Jagatjot changed the title ~~Rebase of PR https://github.com/telefonicaid/iotagent-node-lib/pull/775~~ Rebase of PR #775 "cgroups" literal in configuration group operations URL Apr 24, 2019

Jagatjot mentioned this pull request Apr 24, 2019

Added "cgroups" literal in configuration group operations URL #775

Closed

Update deviceGroupAdministrationServer.js

cd3818d

fgalan reviewed Apr 29, 2019

View reviewed changes

fgalan mentioned this pull request Apr 29, 2019

Change configuration group operations URL to some more meaninfull #752

Open

fgalan reviewed Apr 29, 2019

View reviewed changes

Update CHANGES_NEXT_RELEASE

ee0d509

fgalan mentioned this pull request Apr 30, 2019

[WIP] RENAME /iot/services -> /iot/configGroups in IOTA API telefonicaid/thinking-cities#117

Open

Jagatjot and others added 10 commits May 31, 2019 09:47

Update deviceGroupAdministrationServer.js

d9d3671

Update iotam-autoregistration-test.js

7f4e940

Update mongodb-group-registry-test.js

662addb

Update iotam-autoregistration-test.js

01f8bc4

Update device-group-api-test.js

f12ff77

Update device-group-utils_test.js

800367e

Update singleConfigurationMode-test.js

f90ddfb

Update README.md

d21ca42

Update CHANGES_NEXT_RELEASE

1cb775d

Merge branch 'master' into cnf

92973db

fgalan reviewed Jun 3, 2019

View reviewed changes

Jagatjot added 2 commits June 6, 2019 10:16

Update CHANGES_NEXT_RELEASE

d4ddf8e

Merge branch 'master' into cnf

7b55225

Jagatjot added 11 commits June 16, 2020 18:34

Update iotam-autoregistration-configurationGrouptest.js

f4591cc

Update deviceGroupAdministrationServer.js

a3a50c2

Update deviceGroupAdministrationServer.js

941f895

Create groupConfigService.js

d6a9eb3

Create deviceConfigGroupAdministration.js

877c8b0

Update deviceGroupAdministrationServer.js

8c13700

Create mongodb-ConfigGroup-registry-test.js

acae699

Update mongodb-group-registry-test.js

379a18f

Create iotam-autoregistration-Configtest.js

6ed83bd

Update iotam-autoregistration-test.js

5a6295d

Update CHANGES_NEXT_RELEASE

dacb188

Jagatjot requested a review from fgalan June 22, 2020 14:52

Jagatjot added 8 commits June 22, 2020 21:27

Merge branch 'master' into cnf

c708c33

Delete iotam-autoregistration-configurationGrouptest.js

0944fd5

Update iotam-autoregistration-test.js

5ad9075

Delete mongodb-ConfigGroup-registry-test.js

9437c98

Update mongodb-group-registry-test.js

896c062

Delete iotam-autoregistration-Configtest.js

00915c0

Update iotam-autoregistration-test.js

36bbf30

Create device-Configgroup-api-test.js

609087e

fgalan mentioned this pull request Jul 14, 2020

Should every IoT Agent align to use eslint #830

Closed

Jagatjot closed this Sep 21, 2020

Jagatjot deleted the cnf branch September 21, 2020 08:36

fgalan added a commit that referenced this pull request Oct 7, 2020

ADD cgroups renaming porting old PR #780

6d1f7fe

fgalan mentioned this pull request Oct 7, 2020

[WIP] "configGroups" literal in configuration group operations URL (old PR #780) #922

Closed

fgalan mentioned this pull request Feb 7, 2022

Added Feature/config groups #1198

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase of PR #775 "configGroups" literal in configuration group operations URL #780

Rebase of PR #775 "configGroups" literal in configuration group operations URL #780

Jagatjot commented Apr 24, 2019

Jagatjot commented Apr 24, 2019 •

edited

Loading

fgalan Apr 29, 2019 •

edited

Loading

fgalan Apr 29, 2019

Jagatjot Apr 29, 2019

fgalan May 22, 2019

fgalan Apr 1, 2020

fgalan Apr 29, 2019

Jagatjot Apr 29, 2019

fgalan May 22, 2019

fgalan Apr 1, 2020

fgalan Apr 29, 2019

Jagatjot Apr 29, 2019 •

edited

Loading

fgalan commented May 22, 2019

fgalan commented May 30, 2019

Jagatjot commented May 31, 2019

fgalan Jun 3, 2019

fgalan Apr 1, 2020

Jagatjot commented Jun 22, 2020

fgalan commented Jun 22, 2020

fgalan commented Oct 7, 2020

Jagatjot commented Oct 7, 2020 •

edited by fgalan

Loading

		@@ -717,7 +717,7 @@ The IoT Agents provide two means to define those device groups:
		- Static Type Configuration: configuring the `ngsi.types` property in the

Rebase of PR #775 "configGroups" literal in configuration group operations URL #780

Rebase of PR #775 "configGroups" literal in configuration group operations URL #780

Conversation

Jagatjot commented Apr 24, 2019

Jagatjot commented Apr 24, 2019 • edited Loading

fgalan Apr 29, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jagatjot Apr 29, 2019 • edited Loading

Choose a reason for hiding this comment

fgalan commented May 22, 2019

fgalan commented May 30, 2019

Jagatjot commented May 31, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jagatjot commented Jun 22, 2020

fgalan commented Jun 22, 2020

fgalan commented Oct 7, 2020

Jagatjot commented Oct 7, 2020 • edited by fgalan Loading

Jagatjot commented Apr 24, 2019 •

edited

Loading

fgalan Apr 29, 2019 •

edited

Loading

Jagatjot Apr 29, 2019 •

edited

Loading

Jagatjot commented Oct 7, 2020 •

edited by fgalan

Loading