Removal of Node 6 #783

jason-fox · 2019-04-30T09:01:55Z

Fixes #700

Remove 6 from travis - add 12
Update minimum node engine to 8
Update dependencies to latest Node 8

* Remove 6 from travis - add 8 * Update minimum node engine * Update dependencies to latest Node 8

jason-fox · 2019-04-30T09:02:39Z

fgalan · 2019-04-30T18:22:05Z

package.json

@@ -38,31 +38,31 @@
    "watch": "watch 'npm test && npm run lint' ./lib ./test"
  },
  "dependencies": {


Are the dependencies and devDependencies changed motivated by the node 12 addition? In other words, if the modules are not upgraded this way node 12 job in travis fails?

No, as summarized in the intro, they have been updated to the latest supported version for node 8 - this closes several outstanding vulnerabilities which were present due to using outdated version.

I had assumed that the older versions were being kept for node 6 support.

Please add the changes to CHANGES_NEXT_RELEASE in this style:

- Upgrade from node-uuid ~1.4.1 to uuid ~3.3.2

fgalan · 2019-04-30T18:23:15Z

.travis.yml

@@ -1,9 +1,9 @@
 language: node_js


A line in CHANGES_NEXT_RELEASE about the removal of Node 6 should be include. For homogeneity, I'd suggest to use the same in telefonicaid/iotagent-json#400:

Set Nodejs 8 as minimum version in packages.json (effectively removing Nodev6 from supported versions)

Fixed: ab10c3b

fgalan · 2019-05-22T11:04:44Z

package.json

-    "mongodb": "3.1.8",
-    "mongoose": "5.3.6",
+    "moment": "~2.24.0",
+    "moment-timezone": "^0.5.25",


^ -> ~, please

fgalan · 2019-05-22T11:05:58Z

IOTA Node Lib version 2.9.0 has been just released, so this PR gets "unblocked" and can progress. Please have a look to new comments and solve the conflicts on CHANGES_NEXT_RELEASE.

Merge branch 'master' into feature/node-6

fgalan · 2019-06-04T13:52:22Z

CHANGES_NEXT_RELEASE

@@ -0,0 +1,2 @@
+- Upgrade from node-uuid ~1.4.1 to uuid ~3.3.2


This was only an example to show style. In fact, it is not correct this time as uuid didn't change in pacakges.json in this PR. Sorry for not being clearer...

I'll try to provide a real example for a dependency and another for dev dependency:

- Upgrade async dependency from 2.6.1 to 2.6.2 - Upgrade mocha dev dependency from 5.2.0 to 6.1.4

All changes in packages.json dependencies and dev dependencies should be included this way in CHANGES_NEXT_RELEASE.

Fixed 50476d3

fgalan · 2019-06-04T13:53:15Z

package.json

  },
  "devDependencies": {
-    "coveralls": "~3.0.2",
+    "coveralls": "^3.0.3",


^ -> ~, pls

Fixed 6162b64

fgalan · 2019-06-04T14:36:16Z

We prefer to include the ~ detail in the changelog. However, in order to simplify your work ;) I include bellow the new version of CNR with this taken into account. Just copy-paste it and upgrade the PR.

- Upgrade async dependency from 2.6.1 to 2.6.2
- Upgrade body-parser dependency from ~1.18.3 to ~1.19.0
- Upgrade moment dependency from ~2.22.2 to ~2.24.0
- Upgrade moment-timezone dependency from ~0.5.21 to ~0.5.25
- Upgrade mongodb dependency from 3.1.8 to 3.2.3
- Upgrade mongoose dependency from 5.3.6 to 5.5.4
- Upgrade query-string dependency from 6.2.0 to 6.5.0
- Upgrade coveralls dev dependency from ~3.0.2 to ~3.0.3
- Upgrade jshint dev dependency from ~2.9.6 to ~2.10.2
- Upgrade mocha dev dependency from 5.2.0 to 6.1.4
- Upgrade nock dev dependency from 10.0.1 to 10.0.6
- Upgrade timekeeper dev dependency from 2.1.2 to 2.2.0
- Set Nodejs 8 as minimum version in packages.json (effectively removing Nodev6 from supported versions)

jason-fox · 2019-06-05T09:34:01Z

Upgrade async dependency from 2.6.1 to 2.6.2
... etc.

Set Nodejs 8 as minimum version in packages.json (effectively removing Nodev6 from supported versions)

Fixed 6cc8714

fgalan

LGTM. Thanks!

Removal of Node 6

addad4e

* Remove 6 from travis - add 8 * Update minimum node engine * Update dependencies to latest Node 8

fgalan reviewed Apr 30, 2019

View reviewed changes

fgalan mentioned this pull request Apr 30, 2019

Remove Node v6 #700

Closed

Add CNR

ab10c3b

fgalan reviewed May 22, 2019

View reviewed changes

package.json Outdated

"mongodb": "3.1.8",

"mongoose": "5.3.6",

"moment": "~2.24.0",

"moment-timezone": "^0.5.25",

Copy link

Member

fgalan May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ -> ~, please

jason-fox added 2 commits June 3, 2019 17:31

Resolving conflicts

fe8cfe0

Merge branch 'master' into feature/node-6

Remove package-lock

f020d8c

fgalan reviewed Jun 4, 2019

View reviewed changes

jason-fox added 2 commits June 4, 2019 16:03

List package changes

50476d3

^ -> ~

6162b64

Amend CNR

6cc8714

fgalan approved these changes Jun 5, 2019

View reviewed changes

fgalan merged commit f188355 into telefonicaid:master Jun 5, 2019

jason-fox deleted the feature/node-6 branch November 20, 2020 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removal of Node 6 #783

Removal of Node 6 #783

jason-fox commented Apr 30, 2019 •

edited

Loading

jason-fox commented Apr 30, 2019

fgalan Apr 30, 2019

jason-fox May 1, 2019

fgalan May 22, 2019

fgalan Apr 30, 2019

jason-fox May 1, 2019

fgalan May 22, 2019

fgalan commented May 22, 2019

fgalan Jun 4, 2019 •

edited

Loading

jason-fox Jun 4, 2019

fgalan Jun 4, 2019

jason-fox Jun 4, 2019

fgalan commented Jun 4, 2019

jason-fox commented Jun 5, 2019

fgalan left a comment

		@@ -0,0 +1,2 @@
		- Upgrade from node-uuid ~1.4.1 to uuid ~3.3.2

Removal of Node 6 #783

Removal of Node 6 #783

Conversation

jason-fox commented Apr 30, 2019 • edited Loading

jason-fox commented Apr 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fgalan commented May 22, 2019

fgalan Jun 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fgalan commented Jun 4, 2019

jason-fox commented Jun 5, 2019

fgalan left a comment

Choose a reason for hiding this comment

jason-fox commented Apr 30, 2019 •

edited

Loading

fgalan Jun 4, 2019 •

edited

Loading