Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[FEAT]] Dont use err.toString as message #26

Merged
merged 1 commit into from
May 15, 2016

Conversation

jmendiara
Copy link
Member

Node v6 adds the stacktrace when you call new Error().toString, which will break our test, and probably many logs analyzers that expects a different format

Date are also serialized in other ways

This is the first commit to try to mitigate this

@coveralls
Copy link

coveralls commented May 15, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 6683102 on fix/dontUseToString into a2f1ef0 on develop.

@palmerabollo
Copy link
Member

LGTM

@palmerabollo palmerabollo merged commit 89a1502 into develop May 15, 2016
@palmerabollo palmerabollo deleted the fix/dontUseToString branch May 15, 2016 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants