-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[[FEAT]] Make node 6 compatible #39
Conversation
1 similar comment
@@ -86,7 +86,7 @@ describe('Development format', function() { | |||
it('should log dates', function() { | |||
var now = new Date(); | |||
logger.info({}, now); | |||
expect(logger._lastTrace).to.be.eql('INFO ' + now); | |||
expect(logger._lastTrace).to.be.eql('INFO 1970-01-01T00:00:00.000Z'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 1970-01-01 and not the current date if you are logging a new Date
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of sinon dark magic at https://github.com/telefonicaid/logops/blob/master/test/environment.js#L20
More Reading at http://sinonjs.org/releases/v1.17.7/fake-timers/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on my side ;)
Related #36