Merge pull request #748 from telefonicaid/task/check_domain_context

check domain before access domain.context
telefonicaid · Sep 26, 2023 · 41e53ad · 41e53ad
2 parents 26214a9 + 2a61f0f
commit 41e53ad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE
@@ -1,3 +1,4 @@
+- Fix: check domain before access domain
 - Fix: expandVar return a 'null' instead of null (#746)
 - Fix: smtp and smpp logs (#738)
 - Add: allow access entities using NGSIv2 API for non_signal rules (new setting nonSignalByAPI / PERSEO_CHECK_NON_SIGNAL_BY_API) (#549)

diff --git a/lib/myutils.js b/lib/myutils.js
@@ -143,7 +143,7 @@ function requestHelperAux(method, options, withMetrics, callback) {
         }
     }
     options.headers = headers;
-    if (withMetrics && options.json && domain.context) {
+    if (withMetrics && options.json && domain && domain.context) {
         try {
             metrics.IncMetrics(
                 domain.context.srv,
@@ -157,7 +157,7 @@ function requestHelperAux(method, options, withMetrics, callback) {
     }
     request[method](options, function cbRequest2core(err, response, body) {
         var bodySz = 0;
-        if (withMetrics && domain.context) {
+        if (withMetrics && domain && domain.context) {
             if (body) {
                 if (typeof body === 'string') {
                     bodySz = Buffer.byteLength(body);
@@ -178,7 +178,7 @@ function requestHelperAux(method, options, withMetrics, callback) {
         }
         if (err) {
             logErrorIf(err, util.format('error %s to %s', method, options.url));
-            if (withMetrics && domain.context) {
+            if (withMetrics && domain && domain.context) {
                 metrics.IncMetrics(domain.context.srv, domain.context.subsrv, metrics.outgoingTransactionsErrors);
             }
             return callback(err, null);
@@ -196,7 +196,7 @@ function requestHelperAux(method, options, withMetrics, callback) {
             );
             localError.httpCode = respObj.code < 500 && respObj.code >= 400 ? respObj.code : 500;
             logErrorIf(localError, null, domain && domain.context);
-            if (withMetrics && domain.context) {
+            if (withMetrics && domain && domain.context) {
                 metrics.IncMetrics(domain.context.srv, domain.context.subsrv, metrics.outgoingTransactionsErrors);
             }
             return callback(localError, respObj);