Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace findOne + orderBy to find + sort + limit #340

Merged
merged 6 commits into from
May 24, 2019
Merged

replace findOne + orderBy to find + sort + limit #340

merged 6 commits into from
May 24, 2019

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented May 23, 2019 •
edited

@AlvaroVega AlvaroVega changed the title replace findOne + orderBy to find + sort + limit [WIP] replace findOne + orderBy to find + sort + limit May 23, 2019
@AlvaroVega AlvaroVega changed the title [WIP] replace findOne + orderBy to find + sort + limit replace findOne + orderBy to find + sort + limit May 24, 2019
@AlvaroVega
Copy link
Member Author

To be merged with squash

@AlvaroVega AlvaroVega requested a review from fgalan May 24, 2019 06:02
fgalan
fgalan reviewed May 24, 2019
View reviewed changes
lib/models/executionsStore.js
@@ -42,19 +42,27 @@ module.exports = {
myutils.logErrorIf(err);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGES_NEXT_RELEASE entry missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 13388f3

@AlvaroVega AlvaroVega mentioned this pull request May 24, 2019
Closed
fgalan
fgalan approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit f348259 into master May 24, 2019
@fgalan fgalan deleted the task/replace_findOne_to_find branch May 24, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlvaroVega @fgalan