Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set None as default entity type if not valid type is provided #612

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Set None as default entity type if not valid type is provided #612

merged 3 commits into from
Dec 10, 2021

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Nov 29, 2021 •
edited
Loading

fix for #611

@AlvaroVega AlvaroVega changed the title Set None as default entity type if not valid type is provided [WIP] Set None as default entity type if not valid type is provided Nov 29, 2021
@AlvaroVega AlvaroVega changed the title [WIP] Set None as default entity type if not valid type is provided Set None as default entity type if not valid type is provided Dec 2, 2021
fgalan
fgalan approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 9313de9 into master Dec 10, 2021
@fgalan fgalan deleted the task/set_default_entity_type_update_rule branch December 10, 2021 09:42
@fgalan fgalan mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlvaroVega @fgalan