Add graceful shutdown #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a shutdown signal is sent, we need to do graceful shutdown out of Node.js and Express to avoid side effects like finishing active requests before closing server, clean up resources, db connections etc. see: https://stackfame.com/node-express-graceful-shutdown
fgalan
reviewed
Dec 21, 2021
| @@ -194,6 +194,15 @@ npm run | |||
|
|
|||
There was a problem hiding this comment.
CHANGES_NEXT_RELEASE entry as in PR telefonicaid/iotagent-json#606, pls.
There was a problem hiding this comment.
Fixed Fixed 6f9106f
fgalan
reviewed
Dec 21, 2021
lib/sigfoxServer.js
Outdated
| * | ||
| */ | ||
| function handleShutdown(signal) { | ||
| config.getLogger().fatal(context, 'Received %s, starting shutdown processs', signal); |
There was a problem hiding this comment.
Should be info, as in PR telefonicaid/iotagent-json#606
There was a problem hiding this comment.
I'd already done that - just didn't push. Fixed 6f9106f
fgalan
reviewed
Dec 21, 2021
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a shutdown signal is sent, we need to do graceful shutdown out of Node.js and Express to avoid side effects
like finishing active requests before closing server, clean up resources, db connections etc.
see: https://stackfame.com/node-express-graceful-shutdown