Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent update broke unread message badge counter #10263

Closed
Entropy0 opened this issue Jan 29, 2021 · 13 comments
Closed

Recent update broke unread message badge counter #10263

Entropy0 opened this issue Jan 29, 2021 · 13 comments

Comments

@Entropy0
Copy link

Entropy0 commented Jan 29, 2021

Steps to reproduce

  1. Install most recent version
  2. Set "Count unread messages" to true
    2.a. Set "Include muted chats in unread count" to true
  3. Wait until you get a message

Expected behaviour

A badge with the number of unread messages appears on the tray icon.
The badge will be grey if you selected to include muted chats and the message is in a muted chat.

Actual behaviour

Only a tiny, barely discernible blue dot appears, but no number.
No dot appears whatsoever for messages in muted chats.

Configuration

Operating system:
Linux
Version of Telegram Desktop:
2.5.7
Installation source (Linux Only) - the official website / GitHub releases / flatpak / snap / distribution package:
official website
Used theme:
default

@ilya-fedin
Copy link
Contributor

It depends on icon theme you chosen. If you have an icon theme with a dot indicator, counter overlay won't be added.

@Entropy0
Copy link
Author

It used to work just fine up until the most recent update.

But I cycled through all the available themes nevertheless and found that the telegram icon stays the same no matter which theme I select while the rest of the icons in the tray vary wildly.

@ilya-fedin
Copy link
Contributor

It used to work just fine up until the most recent update.

Yeah, the behavior was changed since most users except monochrome icon to not to be overlapped by the counter.

But I cycled through all the available themes nevertheless and found that the telegram icon stays the same no matter which theme I select while the rest of the icons in the tray vary wildly.

Have you restarted tdesktop after each icon theme change?

@Entropy0
Copy link
Author

Entropy0 commented Jan 29, 2021

It used to work just fine up until the most recent update.

Yeah, the behavior was changed since most users except monochrome icon to not to be overlapped by the counter.

Honestly, I don't want a monochrome icon at all - I was far more happy with the old blue-and-white one. But sadly Telegram seems to be ignoring the ones I put into ~/.local/share/TelegramDesktop/tdata/ticons so I was fine with the monochrome version - as long as there was a counter :-/
Not to mention that I would expect the GUI option to "Count unread messages" to actually count unread messages!

But I cycled through all the available themes nevertheless and found that the telegram icon stays the same no matter which theme I select while the rest of the icons in the tray vary wildly.

Have you restarted tdesktop after each icon theme change?

I have now: Still no change to the icon at all.

Do you know of a mate-theme that should have the badge counter visible so that I can confirm whether this works as intended?

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jan 29, 2021

Do you know of a mate-theme that should have the badge counter visible so that I can confirm whether this works as intended?

Badge counter will be visible as long as your icon theme doesn't have telegram{,-mute,-attention}-panel icons.
If you use MATE, please note that your distro maintainer disabled GTK integration and there are no guarantee that tdesktop will behave correctly due to this. looks like I confused with another issue, there are no logs.

@Entropy0
Copy link
Author

I double-checked now by manually installing a theme and checking for the files you mentioned and it appears that Telegram simply ignores whatever icon the theme provides - it is always the same default white one, regardless of whether the theme contains any of panel/*/telegram{,-mute,-attention}-panel.svg or not.

And mate does support gtk just fine otherwise…

If you tell me what logs you need I would be happy to provide them.

@grayich
Copy link

grayich commented Jan 29, 2021

same
the topic has not changed, the counter has disappeared

make the counter be independent of the theme
there is no life without a counter

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jan 29, 2021

And mate does support gtk just fine otherwise…

I mean tdesktop gtk integration. Some distro maintainers disable it. tdesktop will write to terminal if that's the case.

it is always the same default white one, regardless of whether the theme contains any of panel/*/telegram{,-mute,-attention}-panel.svg or not.

Can you show how it looks like? It's also worth to check the value of echo $QT_QPA_PLATFORMTHEME, maybe you're using something like qt5ct, you should change qt5ct settings then.

@ilya-fedin
Copy link
Contributor

make the counter be independent of the theme

Currently no way. See #6721. Adding options requires permission from @john-preston and he doesn't give one.

@Entropy0
Copy link
Author

And mate does support gtk just fine otherwise…

I mean tdesktop gtk integration. Some distro maintainers disable it. tdesktop will write to terminal if that's the case.

The only output Telegram gives when starting is

[ALSOFT] (EE) Failed to set real-time priority for thread: Operation not permitted (1)
error: : cannot open
error: : cannot open
error: : cannot open

it is always the same default white one, regardless of whether the theme contains any of panel/*/telegram{,-mute,-attention}-panel.svg or not.

Can you show how it looks like? It's also worth to check the value of echo $QT_QPA_PLATFORMTHEME, maybe you're using something like qt5ct, you should change qt5ct settings then.

Interesting, I had never heard of qt5ct. For some reason every try icon other than that of Telegram is controlled by setting the theme via mate-appearance-properties but Telegram (and only Telegram) adheres to the changes set by qt5ct. Weird.

For anyone who stumbles upon this thread via google:
If a theme doesn't have any panel/*/telegram{,-mute,-attention}-panel.svg, the icon that gets displayed is chosen from apps/*/ instead of panel/*/ (org.telegram.desktop.svg, telegram-desktop.svg and telegram.svg all seem to be found) and doesn't have any indicator at all (neither little dot not counter).
And if a theme doesn't have an icon there the tray icon simply disappears when activating it via qt5ct but if you then click the spot where it should be it reappears as the default icon and has a badge counter!

Thank you for the help @ilya-fedin !

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jan 29, 2021

For some reason every try icon other than that of Telegram is controlled by setting the theme via mate-appearance-properties but Telegram (and only Telegram) adheres to the changes set by qt5ct. Weird.

Because Telegram is a Qt application. If you will install something like VLC or qBittorrent, they will also be controlled by qt5ct...

@ilya-fedin
Copy link
Contributor

If a theme doesn't have any panel/*/telegram{,-mute,-attention}-panel.svg, the icon that gets displayed is chosen from apps/*/ instead of panel/*/ (org.telegram.desktop.svg, telegram-desktop.svg and telegram.svg all seem to be found) and doesn't have any indicator at all (neither little dot not counter).

I checked and I see that the counter is present in that case, as it supposed to:
image

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants