Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure against Qt < 5.15 #10398

Closed
xvitaly opened this issue Feb 18, 2021 · 3 comments
Closed

Build failure against Qt < 5.15 #10398

xvitaly opened this issue Feb 18, 2021 · 3 comments

Comments

@xvitaly
Copy link
Contributor

xvitaly commented Feb 18, 2021

Steps to reproduce

  1. Build against Qt < 5.15

Expected behaviour

Successful build.

Actual behaviour

Build failure:

../Telegram/lib_ui/ui/platform/ui_platform_window_title.cpp: In member function 'virtual void Ui::Platform::DefaultTitleWidget::mouseMoveEvent(QMouseEvent*)':
../Telegram/lib_ui/ui/platform/ui_platform_window_title.cpp:334:29: error: 'class QWindow' has no member named 'startSystemMove'
  334 |   window()->windowHandle()->startSystemMove();
      |                             ^~~~~~~~~~~~~~~
[333/857] /usr/bin/c++  -DDESKTOP_APP_DISABLE_CRASH_REPORTS -DDESKTOP_APP_DISABLE_WAYLAND_INTEGRATION -DDESKTOP_APP_USE_PACKAGED -DDESKTOP_APP_USE_PACKAGED_FONTS -DNDEBUG -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -ITelegram/lib_ui/lib_ui_autogen/include -ITelegram/lib_ui/gen -I../Telegram/lib_ui -I../Telegram/lib_ui/emoji_suggestions -I../Telegram/lib_base -I../Telegram/lib_rpl -I../Telegram/lib_crl -isystem /usr/include/qt5/QtCore/5.14.2 -isystem /usr/include/qt5/QtCore/5.14.2/QtCore -isystem /usr/include/qt5/QtGui/5.14.2 -isystem /usr/include/qt5/QtGui/5.14.2/QtGui -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtDBus -isystem /usr/share -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -O2 -g1 -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG   -fPIC -fno-strict-aliasing -pipe -Wall -W -Wno-unused-variable -Wno-unused-parameter -Wno-unused-function -Wno-switch -Wno-comment -Wno-unused-but-set-variable -Wno-missing-field-initializers -Wno-sign-compare -Wno-attributes -Wno-parentheses -Wno-stringop-overflow -Wno-maybe-uninitialized -Wno-error=class-memaccess -Wno-register -pthread -std=gnu++17 -Winvalid-pch -include /builddir/build/BUILD/tdesktop-2.5.9-full/x86_64-redhat-linux-gnu/Telegram/lib_ui/CMakeFiles/lib_ui.dir/cmake_pch.hxx -MD -MT Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/linux/ui_utility_linux.cpp.o -MF Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/linux/ui_utility_linux.cpp.o.d -o Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/linux/ui_utility_linux.cpp.o -c ../Telegram/lib_ui/ui/platform/linux/ui_utility_linux.cpp
[334/857] /usr/bin/c++  -DDESKTOP_APP_DISABLE_CRASH_REPORTS -DDESKTOP_APP_DISABLE_WAYLAND_INTEGRATION -DDESKTOP_APP_USE_PACKAGED -DDESKTOP_APP_USE_PACKAGED_FONTS -DNDEBUG -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -ITelegram/lib_ui/lib_ui_autogen/include -ITelegram/lib_ui/gen -I../Telegram/lib_ui -I../Telegram/lib_ui/emoji_suggestions -I../Telegram/lib_base -I../Telegram/lib_rpl -I../Telegram/lib_crl -isystem /usr/include/qt5/QtCore/5.14.2 -isystem /usr/include/qt5/QtCore/5.14.2/QtCore -isystem /usr/include/qt5/QtGui/5.14.2 -isystem /usr/include/qt5/QtGui/5.14.2/QtGui -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtDBus -isystem /usr/share -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -O2 -g1 -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG   -fPIC -fno-strict-aliasing -pipe -Wall -W -Wno-unused-variable -Wno-unused-parameter -Wno-unused-function -Wno-switch -Wno-comment -Wno-unused-but-set-variable -Wno-missing-field-initializers -Wno-sign-compare -Wno-attributes -Wno-parentheses -Wno-stringop-overflow -Wno-maybe-uninitialized -Wno-error=class-memaccess -Wno-register -pthread -std=gnu++17 -Winvalid-pch -include /builddir/build/BUILD/tdesktop-2.5.9-full/x86_64-redhat-linux-gnu/Telegram/lib_ui/CMakeFiles/lib_ui.dir/cmake_pch.hxx -MD -MT Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/ui_platform_window.cpp.o -MF Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/ui_platform_window.cpp.o.d -o Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/ui_platform_window.cpp.o -c ../Telegram/lib_ui/ui/platform/ui_platform_window.cpp
FAILED: Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/ui_platform_window.cpp.o 
/usr/bin/c++  -DDESKTOP_APP_DISABLE_CRASH_REPORTS -DDESKTOP_APP_DISABLE_WAYLAND_INTEGRATION -DDESKTOP_APP_USE_PACKAGED -DDESKTOP_APP_USE_PACKAGED_FONTS -DNDEBUG -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -ITelegram/lib_ui/lib_ui_autogen/include -ITelegram/lib_ui/gen -I../Telegram/lib_ui -I../Telegram/lib_ui/emoji_suggestions -I../Telegram/lib_base -I../Telegram/lib_rpl -I../Telegram/lib_crl -isystem /usr/include/qt5/QtCore/5.14.2 -isystem /usr/include/qt5/QtCore/5.14.2/QtCore -isystem /usr/include/qt5/QtGui/5.14.2 -isystem /usr/include/qt5/QtGui/5.14.2/QtGui -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtDBus -isystem /usr/share -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -O2 -g1 -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG   -fPIC -fno-strict-aliasing -pipe -Wall -W -Wno-unused-variable -Wno-unused-parameter -Wno-unused-function -Wno-switch -Wno-comment -Wno-unused-but-set-variable -Wno-missing-field-initializers -Wno-sign-compare -Wno-attributes -Wno-parentheses -Wno-stringop-overflow -Wno-maybe-uninitialized -Wno-error=class-memaccess -Wno-register -pthread -std=gnu++17 -Winvalid-pch -include /builddir/build/BUILD/tdesktop-2.5.9-full/x86_64-redhat-linux-gnu/Telegram/lib_ui/CMakeFiles/lib_ui.dir/cmake_pch.hxx -MD -MT Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/ui_platform_window.cpp.o -MF Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/ui_platform_window.cpp.o.d -o Telegram/lib_ui/CMakeFiles/lib_ui.dir/ui/platform/ui_platform_window.cpp.o -c ../Telegram/lib_ui/ui/platform/ui_platform_window.cpp
../Telegram/lib_ui/ui/platform/ui_platform_window.cpp: In lambda function:
../Telegram/lib_ui/ui/platform/ui_platform_window.cpp:130:30: error: 'class QWindow' has no member named 'startSystemMove'
  130 |     _window->windowHandle()->startSystemMove();
      |                              ^~~~~~~~~~~~~~~
../Telegram/lib_ui/ui/platform/ui_platform_window.cpp: In lambda function:
../Telegram/lib_ui/ui/platform/ui_platform_window.cpp:207:31: error: 'class QWindow' has no member named 'startSystemResize'
  207 |     window()->windowHandle()->startSystemResize(edges);
      |                               ^~~~~~~~~~~~~~~~~

Configuration

Operating system: Fedora 32

Version of Telegram Desktop: 2.5.9

Installation source (Linux Only) - the official website / GitHub releases / flatpak / snap / distribution package: build from sources

Used theme: n/a

Logs: Insert log.txt here (if necessary)
@xvitaly
Copy link
Contributor Author

xvitaly commented Feb 18, 2021

startSystemMove() and startSystemResize() are available only in Qt 5.15+.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Feb 18, 2021 •
edited
Loading

Yeah, we discussed at the tdesktop contributions group and no one was against deprecating the build on Qt<5.15. So, it's deprecated starting with 2.5.9. Next versions will provide cleanup for the remaining hacks for the old Qt versions.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Mar 24, 2021
@bmwiedemann
Update telegram-desktop to version 2.7.1 / rev 55 via SR 880737
760f57b 
https://build.opensuse.org/request/show/880737
by user tux93 + dimstar_suse
- Expand the ExcludeArch.

- Exclude i586, support was dropped upstream
  (gh#telegramdesktop/tdesktop#10037)

- Add telegram-desktop-cinttypes-header.patch: Include cinttypes
  header to use uint32_t.
- Add xkbcommon and wayland header dirs to CXXFLAGS to fix build
  failures.
- Require Qt >= 5.15: Required since version 2.5.9
  (gh#telegramdesktop/tdesktop#10398).
- Pass -q to unzip to avoid echoing long file list while
  unzipping.

- Update to 2.7.1
  * Fix editing 'Manage Voice Chats' rights for channel admins.
  * Fix verification check display in voice chat participants list.
  * Allow removing and blocking channels from voice chats.
- Update tg_owt

- Update to 2.7.0
  * Start limitless Voice Chats in Groups and Channels.
  * Host discussions that can be listened to by millions of p
@github-actions
Copy link

github-actions bot commented Apr 4, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Aokromes @xvitaly @ilya-fedin