Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong size of local storage #2244

Closed
srazi opened this issue Jul 12, 2016 · 6 comments
Closed

Wrong size of local storage #2244

srazi opened this issue Jul 12, 2016 · 6 comments
Labels
bug

Comments

@srazi
Copy link
Contributor

srazi commented Jul 12, 2016

Steps to reproduce

  1. You need to have a big local storage, I'm not sure big means a lot of files or for example a local storage bigger than 1 GB

Expected behaviour

It should show correct size of local storage

Actual behaviour

It shows negative size.
bug-tdesktop-0 9 56

Configuration

Operating system:
Windows 10 - 64 Bit
Version of Telegram Desktop:
0.9.56 and also all other versions
@z3ntu
Copy link

z3ntu commented Jul 16, 2016 •
edited
Loading

Looks like there is a signed long in use. Max should be 2147483647 then (which is about 2.14 Gigabytes).

@auchri auchri added the bug label Jul 23, 2016
@srazi
Copy link
Contributor Author

srazi commented Jul 31, 2016

It seems @z3ntu is right, and fix is as easy as changing int32 to qint64 at localstorage.cpp#L586

@z3ntu
Copy link

z3ntu commented Jul 31, 2016

@john-preston This should be easy to fix, right?

@stek29
Copy link
Contributor

stek29 commented Aug 20, 2016

And what if int64 overflows too?
IMO it should be better to use float and show approximate size...

This was referenced Jul 13, 2017
Closed
Closed
@silverfoxy silverfoxy mentioned this issue Jul 19, 2017
Closed
@auchri auchri closed this as completed Dec 3, 2017
@puppy0cam
Copy link

puppy0cam commented Apr 30, 2019 •
edited
Loading

This appears to still be an issue in version 1.6.7
image

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@srazi @z3ntu @auchri @puppy0cam @stek29