Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX: Ctrl + Option + "Б" and Ctrl + Option + "Ю" not works #24915

Closed
dm3ch opened this issue Aug 12, 2022 · 18 comments
Closed

OSX: Ctrl + Option + "Б" and Ctrl + Option + "Ю" not works #24915

dm3ch opened this issue Aug 12, 2022 · 18 comments

Comments

@dm3ch
Copy link

dm3ch commented Aug 12, 2022

Steps to reproduce

Try to print dot or comma using described below key combinations on macOS standard Russian layout.

Expected behaviour

. should be printed when ctrl+option+> (ю) pressed
, should be printed when ctrl+option+< (б) pressed

Actual behaviour

Nothing printed when specified key combinations pressed

Operating system

MacOS 12.4

Version of Telegram Desktop

v4.1

Installation source

Static binary from official website

Logs

No response

@dm3ch dm3ch added the bug label Aug 12, 2022
@dm3ch
Copy link
Author

dm3ch commented Aug 12, 2022

Actually, there is an old already closed issue describing the same problem #2468

The only information I found there is to look into #1060 , but I wasn't able to find any related info.

P.S. Key combinations described in this issue are not some custom shortcuts, but a official way of printing this characters on macOS standard Russian layout (for me it works in all applications except Telegram Desktop)

@ilya-fedin
Copy link
Contributor

Have you checked other Qt applications like qBittorrent or VLC?

@dm3ch
Copy link
Author

dm3ch commented Aug 13, 2022

Have you checked other Qt applications like qBittorrent or VLC?

Just checked in VLC 3.0.17.3 in playlist search input these combinations work fine.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Aug 13, 2022

It's better to check qBittorrent (the one that built with Qt 6). I don't know what Qt version VLC uses on macOS, but on Windows it still uses Qt 4 while tdesktop uses Qt 6, no surprise if there would be big differences in behavior.

@dm3ch
Copy link
Author

dm3ch commented Aug 13, 2022

qBittorent 4.4.3.1 (on QT 6) problem reproduced. Probably you are right and this is a QT issue.

@dm3ch
Copy link
Author

dm3ch commented Sep 7, 2022

Created an issue in QT bug tracker, maybe we would find some help there - https://bugreports.qt.io/browse/QTBUG-106393

@ilya-fedin
Copy link
Contributor

It seems VLC on macOS doesn't use Qt: https://en.wikipedia.org/wiki/VLC_media_player#Interfaces
So it's not really known whether Qt 4 is affected or not

@dm3ch
Copy link
Author

dm3ch commented Sep 18, 2022

QT closed the issue as fixed. They wrote that fix version is: 6.5.0 Beta1

@ilya-fedin
Copy link
Contributor

How fast

@dm3ch
Copy link
Author

dm3ch commented Dec 5, 2022

Created PR with attempt to bump QT version for MacOS build.

I'm not sure if I done this right, but I need workflow approves to try to build it

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Dec 5, 2022

It's sadly not that simple, first the patches in https://github.com/desktop-app/patches should be updated as there are new API uses that break macOS 10.12+ build in Qt. Then ui_window_mac, main_window_mac should be prepared for winId change in runtime as it changes now due to QtWidgets refactoring in Qt 6.4 to support RHI. Maybe changing the order of some calls would be enough though, so OpenGL is initialized before native window creation.

Testing with workflows is not a good thing to do as they go 6+ hours.

@23rd
Copy link
Collaborator

23rd commented Dec 5, 2022

QT closed the issue as fixed. They wrote that fix version is: 6.5.0 Beta1

Are you sure that the 6.4.1 version fixes the problem?

@ilya-fedin
Copy link
Contributor

It seems the fix will be only in 6.4.2

@ilya-fedin
Copy link
Contributor

Ah, it's actually in 6.4.1, but the fix broke some other IM-related thing and now there's yet another fix that will be in 6.4.2

@dm3ch
Copy link
Author

dm3ch commented Dec 5, 2022

Ahh, you are right, just realized that fix version is marked as 6.5.0-Beta1.

About using pipelines for test purposes - I got your point. It seems I'm too much out of scope/experience to do this version bump by myself. :(

@dm3ch
Copy link
Author

dm3ch commented Dec 5, 2022

By the way, if you are already managing patches for Qt in a separate repo, maybe it would be easier to backport a bugfix as a patch to currently used version instead of working on a QT version upgrade?

@23rd
Copy link
Collaborator

23rd commented Dec 5, 2022

I think I can check later how difficult it would be to update the QT version.

@dm3ch
Copy link
Author

dm3ch commented Dec 7, 2022

Just checked today, dot and comma key combinations finally works, TY 🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants