-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thai font broke after upgrade to v4.6.0 #25825
Comments
The v4.6.0 link is unavailable, it's better to load images on github. But there indeed was a change in retrieving default system font for better UX on High-DPI, the used API is upgraded from Windows XP one to the Windows 7 one. So I don't think it's really broken, just a more modern font is used. |
No, it's not possible to change font and adding such an option is non-trivial and is not planned (#90). The API change is backported from Qt 6, can you check any Qt application (e.g. qBittorrent has Qt 6 builds)? If its font is good then maybe the backport is incomplete, if it's the same, it's better to report to Qt and when Qt developers produce a fix, it could be backported. |
Does it use another font or just the text is bigger? |
Also, are you sure you checked qBittorrent built with Qt 6 exactly? Qt 5 version would use the legacy API tdesktop used previously. |
btw, I just checked and I can't reproduce your problem, so it might be that some additionally installed fonts (that may happen even automatically when installing software) caused this. So prepare that Qt developers may not reproduce your problem when you will report this to them and you will have to find what installed the breaking font by installing Windows into VM and installing software you use or copying your host fonts into it. |
You can also try the Linux font rendering engine by typing |
If the question is for me then the answer is no |
Tried 'freetype' & back to GDI. No difference. I've checked with many friends and they're all having this problem. I'll try changing the default Windows font and see if there's any change to this. I'll report back later |
Hmm, maybe it's a font that is present only in Thai version of Windows? Changing default font is unlikely to help, what you see is likely to be caused by Qt's fallback logic that just tries all the fonts in the system in alphabetical order and picks up the first one that claims to have a glyph for the character. |
This is true, I used the software to copy and rename the font name of "Tahoma" to "_Tahoma" and install it on my Windows. If anyone wants to copy and rename the font name, you can use the software named "FontForge" or "Typograf". |
I'd like to add that a popular workaround for Chinese font issue on English systems is also broken in v4.6. In English installations of Windows 10, the default font fallback lists all put Microsoft JhengHei (MSJH, Japanese font) above Microsoft YaHei (MSYH, Simp./Trad. Chinese), causing streams of Chinese characters to be rendered in both fonts. A common solution is editing the registry to manually prioritize MSYH over MSJH (link), which worked until TDesktop v4.6. I have dug through the registry for hours and could not get the same solution to work anymore. |
@likecyber Can you elaborate a bit more on this? Did you install a copy of the Tahoma font as "_Tahoma"? Did you remove the original Tahoma font (i.e. the system no longer has a font named "Tahoma")? |
Yes, I did install a copy of the Tahoma font family as "_Tahoma". (tahoma.ttf + tahomabd.ttf) The reason behind putting the underscore before the name is to make it the first font for alphabetical order fallback. This way I will also have the original Tahoma and a copy of Tahoma on the same computer. |
|
If anyone really needs a quick fix for this issue, you may install the fonts I renamed from this repository. It should work for any language that uses Tahoma as the display font in the previous version. |
This works so well. You save my life! Thank you soooooo much. TT |
@likecyber Thank you soooooo much.you good bro |
@Aokromes You've merged the Hebrew issue with this one, but none of the suggested workarounds here resolve the Hebrew one. At least for me. |
It likely means Hebrew is a part of Segoe UI and so is not a bug. If you don't like the font size, well, you can change scale. |
Using Thai and also faced the same problem. |
This issue should now be closed. I'll try submit issue to Qt. |
You want to say tdesktop doesn't use Open Sans for Russian on your computer? If it doesn't, can you provide log.txt from |
After update this issue happen to me as well. |
[2023.02.07 11:34:22] Font: from ':/gui/fonts/DAOpenSansRegular.ttf' loaded 'DAOpenSansRegular' |
Can you provide the full log? |
I don't want to filter my "private" parts, but if you tell exactly what are you need, I can provide it |
The same issue for text in Chinese on the Simplified Chinese system. Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows NT\CurrentVersion\FontSubstitutes]
"DAOpenSans"="Microsoft YaHei UI"
"DAOpenSansBold"="Microsoft YaHei UI Bold"
"DAOpenSansBoldItalic"="Microsoft YaHei"
"DAOpenSansRegular"="Microsoft YaHei"
"DAOpenSansRegularItalic"="Microsoft YaHei"
"DAOpenSansSemibold"="Microsoft YaHei"
"DAOpenSansSemiboldItalic"="Microsoft YaHei"
"DAVazir"="Microsoft YaHei"
"DAVazirBold"="Microsoft YaHei Bold"
"DAVazirMedium"="Microsoft YaHei Light"
"DAVazirRegular"="Microsoft YaHei"
;; Priority font resolving: "Cascadia Mono", "Consolas", "Liberation Mono", "Menlo", "Courier"
;; Override monospace font:
"Cascadia Mono"="Consolas" |
@7Vlad the log.txt has no private parts |
Fix Chinese font issue |
Has the latest version 4.6.2 fixed this BUG? |
People ask if this reg file affects the system fonts. yes and no. Yes, because the patch is applied to the Windows font replacement mechanism. But this patch is meant to replace those fonts that start with "DA", e.g. "DAOpenSans". So the patch only affects Telegram for those fonts starting with "DA" are ALL of Telegram custom font, no other programs will be affected. |
Of course, it has. Like full path to Telegram directory, full path to taskbar and ALL list of your applications pinned to taskbar, etc. |
I believe it should contain more lines about fonts starting with "Fonts Info:" and "Font Error:" if the font failed to load |
This is what I assumed and therefore all the lines with the word "font"/fonts, I copied above |
Version 4.6.2 seems to fix the issue for Hebrew. |
Version 4.6.2 seems to fix the issue of Thai language for me as well. Anyone who installs my quick fix can remove the fonts and update the Telegram Desktop app to 4.6.2 now. |
Yes.
4.6.2 seems to fix it for me as well (Thai font).
…On Thu, Feb 9, 2023 at 7:14 AM Likecyber ***@***.***> wrote:
Version 4.6.2 seems to fix the issue of Thai language for me as well.
Anyone who installs my quick fix can remove the fonts and update the
Telegram Desktop app to 4.6.2 now.
—
Reply to this email directly, view it on GitHub
<#25825 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APCCWGHB2IYCILE7QDUKDL3WWQZFJANCNFSM6AAAAAAUQ7TR2Q>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I have been waiting for the fix so I stayed at 4.5.3 without updating to 4.6.0 when it was released. Now many people are confirming that 4.6.2 fixed the issue so I updated Telegram Desktop on my PC. I can also confirm that Thai font looks exactly the same as in 4.5.3. Thanks dev team for fixing this quickly! |
I can confirm that the "workaround for Chinese fonts on English systems" is also working again, the same way as it used to in v4.5.3. |
Yes guys v4.6.2 seems to fix Thai font fallback problem for me (win 11) |
Can you provide the screenshot of broken font? For scaling issue provide logs in #25856 |
As you can see on my screenshots (and this is not actual size, because github enlarge the image), first image(4.6.2) fonts is smaller than second(4.5.3). The size was the same on 4.6-4.6.1, but scale was "300%", now, in 4.6.2, it was "fixed", so its show 100% instead of 300%. The key for shortcut "-scale 125" didn't work at all. |
This doesn't seem to be related to fonts and this issue, it's interface scale |
So fonts issue was "fixed" with replacing maximum interface scale from 300% to 100%? |
@7Vlad no, you have a completely another issue, please discuss it in the respective ticket |
yes |
Steps to reproduce
With reference to issue #7845 . The situation is about the same. The previous stable version on Windows OS seems to use Tahoma for displaying Thai language but on v4.6.0 it seems to change to another font which cause Thai word to be too small compare to other.
v4.6.0
https://imgur.com/rvIdiAF
v4.5.3
https://imgur.com/o27t0T9
Expected behaviour
v4.5.3
https://imgur.com/o27t0T9
Actual behaviour
v4.6.0
https://imgur.com/rvIdiAF
Operating system
Windows 11
Version of Telegram Desktop
v4.6.0
Installation source
Static binary from official website
Logs
No response
The text was updated successfully, but these errors were encountered: