Re-add X-GNOME-SingleWindow
#23875
Merged
Re-add X-GNOME-SingleWindow
#23875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you move SingleMainWindow before the X-GNOME keys? |
TheEvilSkeleton
force-pushed
the
x-gnome-singlewindow
branch
from
1319f01
to
ed46136
Compare
|
Done. |
|
No, before the both keys |
|
Oh, sorry about that 😅 |
`X-GNOME-SingleWindow` is best to be used for backward compatibility. Since `SingleMainWindow` was recently added, many Desktop Environments and Window Managers may not have it implemented yet. This MR also moves `SingleMainWindow` before the `X-GNOME-*` keys, as requested in this comment: telegramdesktop#23875 (comment)
TheEvilSkeleton
force-pushed
the
x-gnome-singlewindow
branch
from
ed46136
to
39bde7f
Compare
|
Like this? 39bde7f |
|
Yeah |
SingleMainWindow should be deleted. |
Running this check is mandatory for the most of GNU/Linux distributions and Flatpak. Maintainers will need to manually remove this row. Let's discuss that in #23879. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-GNOME-SingleWindowis best to be used for backward compatibility. SinceSingleMainWindowwas recently added, many Desktop Environments and Window Managers may not have it implemented yet.