Add symbolic app icon #27035
Add symbolic app icon #27035
Conversation
|
Can you explain better why should this be merged? As-is it's not clear what this change would affect. |
This doesn't have any down sides, but when ever the theme (on GNOME but probably also on other platforms) uses a symbolic icon the newly added icon is used, in other places it will keep using the hicolor one. GNOME uses the symbolic icon in the topbar next to the app menu and in notifications when the app doesn't provide a icon for the notification. |
|
So you're proposing a window icon change. I'm not sure that's allowed... |
No it's not. It just uses the symbolic icon in specific places, defined by the platforms theme. For example currently in GNOME the hicolor icon is used in the top bar but made monochrome, because it Telegram doesn't provide a symbolic variant and it would look bad on the platform. How it will look like |
|
You say it's not but I see on your screenshot that the window icon is changed |
This is not the window icon, it's the icon used in the topbar. I mean it's introducing a symbolic variant not a new icon. Btw this is how it looks currently: |
|
This is the same thing, it's just you call it an other way |
|
I've added our svg icon to the repository: https://github.com/telegramdesktop/tdesktop/blob/dev/Telegram/Resources/icons/tray_monochrome.svg Maybe it could be used instead? |
|
Please rebase rather than merging |
GNOME Shell uses the symbolic icon in the topbar and notifications.
jsparber
force-pushed
the
add-symbolic-app-icon
branch
from
a1acd13
to
cfb7238
Compare
Sorry about that. I updated the commit using the icon you added. |
|
@john-preston you maybe (unless you don't want this for official builds) merged this too early as the PR doesn't contain code to install the icon for official build |
what do you mean? |
|
Official build copies the icons in runtime with the code in specific_linux.cpp. This cmake code is no-op for the official build. |
GNOME Shell uses the symbolic icon in some places.