Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pop up emoji tabbed panel and media menu on mouse over #8009

Closed
wants to merge 1 commit into from

Conversation

mymedia2
Copy link
Contributor

@mymedia2 mymedia2 commented Jun 6, 2020

I suggest to not spawn popups on simple mouse over. When a user just moves a mouse, they does not expect to raise any windows. In Telegram, this may lead to really annoying missclicking when the user wishes to send a text or choose a message for reply.

I was going to leave activation a third panel by double left click on emoji button. Although, I did not find an addDoubleClickHandler or similar in Ui::AbstractButton. So for now I use single right click to toggle the third panel in history widget. You may consider this as a start approach.

@vimpostor
Copy link
Contributor

I really don't want to dishonor the work you did for this PR, but I actually really like the existing mouseover feature and would dislike if it was changed. I can't remember ever misclicking due to this feature.

@aemxn
Copy link

aemxn commented Jul 9, 2020

Just wanted to link a specific issue discussion regarding this:

@john-preston
Copy link
Member

Sorry, it works as it is supposed to.

@reallyuniquename
Copy link

@john-preston does it mean there are no plans to implement at least some improvement like popup delay (even ~200ms would be enough)?

Right now it's like you have to play a cursor maze game if you want to touch anything in the right bottom corner of UI and not trigger emoji panel.

@vimpostor
Copy link
Contributor

@reallyuniquename I really cannot understand your cursor maze game... Are you perhaps a touchpad user with a very bad touchpad? I never had any problems with the popup myself, so I am curious why it seems to be such a problem for some people.

@reallyuniquename
Copy link

@magnus-gross it really depends on your workflow. I mainly have two issues. If you run Telegram window maximized system toolbars happen to be right under emoji button, it's almost pixel perfect, I kid you not. I trigger emoji popup like 90% of the time when I touch anything in that corner. Likewise when you finish formatting Telegram message using mouse the shortest cursor path to the Send button goes right through emoji button.

@aemxn
Copy link

aemxn commented Jul 26, 2020

Maximized Telegram window have the ability to put the emoji panel at the right side of the window -- click the emoji button on maximized -- this will solve the problem, though I doubt people are using maximized window all the time.

I think the issue is with people who uses the smallest Telegram window size, the popup will happen if you hover around the bottom right corner.

@Kirrrr
Copy link

Kirrrr commented Aug 3, 2020

Double it.
The option to show emoji popup only after button click wolud be brilliant.

@github-actions
Copy link

github-actions bot commented Mar 3, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants