Dynamically load packed resources from separate file #8667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvitaly
reviewed
Oct 1, 2020
mymedia2
force-pushed
the
patch-23
branch
2 times, most recently
from
74abada
to
dbd1657
Compare
|
I'm not going to use that in my builds of tdesktop (because almost all of them are single-binary), but I can merge it if it is really needed to (more than one?) package maintainers. If the demand is not strong then I'd leave it as it is, because it means less code to maintain. |
This reduces amount of main memory required for linking stage.
ilya-fedin
reviewed
Nov 20, 2020
ilya-fedin
reviewed
Nov 20, 2020
Co-authored-by: ilya-fedin <fedin-ilja2010@ya.ru>
|
Ok, my builds don't support such loading anyway. Can be reopened if it is really needed by more than one downstream maintainers. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may be interested in this patch. It reduces amount of main memory required for linking stage.