Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

The hashname calculation example in node.js did not return the correct result. #126

Merged
merged 1 commit into from
Feb 14, 2015

Conversation

bachp
Copy link
Member

@bachp bachp commented Feb 14, 2015

The result value is not updated and cross checked with the go implementation.

I think it would be good to add some more test vectors for hashname to the specification. Implementations could use them in their tests to verify correctness.

…t result.

The result value is not updated and cross checked with the go implementation.
@quartzjer
Copy link
Member

Thanks for catching that, I thought I had the right one in there. I'd love to get some formal test vectors as well, I have some in https://github.com/telehash/hashname/blob/master/test/hashname.test.js and https://github.com/telehash/telehash-c/blob/master/test/lib_hashname.c and I know @temas has some in his new lib too, perhaps it's time to split it out into a standard list?

quartzjer added a commit that referenced this pull request Feb 14, 2015
The hashname calculation example in node.js did not return the correct result.
@quartzjer quartzjer merged commit c7cf524 into telehash:master Feb 14, 2015
@bachp
Copy link
Member Author

bachp commented Feb 15, 2015

I think a goo place would be to have a list either in the implementers guide or in a separate test vector document in the standard next to the hashname document.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants