Fix issues found by linter #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-strusiewiczsurmacki-mobica
requested review from
MaxRink,
Cellebyte,
chdxD1 and
schrej
as code owners
p-strusiewiczsurmacki-mobica
force-pushed
the
lintissues-fix
branch
from
3ea3182
to
8770111
Compare
schrej
reviewed
Aug 21, 2023
| if addr.Scope != unix.RT_SCOPE_UNIVERSE { | ||
| continue | ||
| } | ||
| info.AnycastGateways = append(info.AnycastGateways, &addr) |
There was a problem hiding this comment.
@chdxD1 this was a bug that is getting fixed in this PR.
By simply referencing it this way, the same address is added multiple times: https://husni.dev/beware-of-implicit-memory-aliasing-in-go-foor-loop/
| if addr.Scope != unix.RT_SCOPE_UNIVERSE { | ||
| continue | ||
| } | ||
| info.AnycastGateways = append(info.AnycastGateways, &addr) |
Co-authored-by: Jakob Schrettenbrunner <dev@schrej.net>
Co-authored-by: Jakob Schrettenbrunner <dev@schrej.net>
Co-authored-by: Jakob Schrettenbrunner <dev@schrej.net>
Co-authored-by: Jakob Schrettenbrunner <dev@schrej.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is continuation of #36
It fixes all the issues found by the golangci-lint configuration introduced in #36.
NOTE: This PR should be fully tested in production-grade test environment before being merged, as I am not able to do so.